Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1584253003: dart2js cps: Fix traversal order in statement rewriter. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Fix traversal order in statement rewriter. The statement rewriter uses a backward traversal, but the visitor for yield and logical operator did not follow this order. Fixes #25460 BUG= R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/27e2977dc725135365dfbbb3bcdb94e31c6246da

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 2 chunks +2 lines, -4 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
asgerf
4 years, 11 months ago (2016-01-14 18:27:47 UTC) #2
Harry Terkelsen
lgtm
4 years, 11 months ago (2016-01-14 18:29:55 UTC) #3
Harry Terkelsen
btw, if you put "Fixes #25460" in the commit message, then github will automatically close ...
4 years, 11 months ago (2016-01-14 18:31:57 UTC) #4
asgerf
4 years, 11 months ago (2016-01-14 18:49:43 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
27e2977dc725135365dfbbb3bcdb94e31c6246da (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698