src/factory.cc - Issue 1584243002: Don't pre-initialise block contexts with holes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/factory.cc

Issue 1584243002: Don't pre-initialise block contexts with holes (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Adapt Turbofan Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/factory.cc

diff --git a/src/factory.cc b/src/factory.cc

index 4701c2154d0efacaed35e0ef433de5145de18775..f03e6b2e6170deabb79d73ce89af07aa077d0b23 100644

--- a/src/factory.cc

+++ b/src/factory.cc

@@ -831,8 +831,7 @@ Handle<Context> Factory::NewWithContext(Handle<JSFunction> function,

Handle<Context> Factory::NewBlockContext(Handle<JSFunction> function,

Handle<Context> previous,

Handle<ScopeInfo> scope_info) {

- Handle<FixedArray> array =

- NewFixedArrayWithHoles(scope_info->ContextLength());

+ Handle<FixedArray> array = NewFixedArray(scope_info->ContextLength());

array->set_map_no_write_barrier(*block_context_map());

Handle<Context> context = Handle<Context>::cast(array);

context->set_closure(*function);