runtime/vm/cha.cc - Issue 1584223006: Remove signature classes from the VM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/cha.cc

Issue 1584223006: Remove signature classes from the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: sync Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/cha.cc

diff --git a/runtime/vm/cha.cc b/runtime/vm/cha.cc

index 667d598fb0263b12aa944f658f194c7a0aabd895..ed5255e664bd9f5d425346fb7753093fe124e65d 100644

--- a/runtime/vm/cha.cc

+++ b/runtime/vm/cha.cc

@@ -49,8 +49,8 @@ bool CHA::HasSubclasses(intptr_t cid) const {

bool CHA::IsImplemented(const Class& cls) {

- // Signature classes have different type checking rules.

- ASSERT(!cls.IsSignatureClass());

+ // Function type aliases have different type checking rules.

+ ASSERT(!cls.IsTypedefClass());

// Can't track dependencies for classes on the VM heap since those are

// read-only.

// TODO(fschneider): Enable tracking of CHA dependent code for VM heap

« no previous file with comments | « runtime/vm/bootstrap_natives.h ('k') | runtime/vm/cha_test.cc » ('j') | no next file with comments »