Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 1584223006: Remove signature classes from the VM. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« runtime/observatory/tests/service/graph_test.dart ('K') | « runtime/vm/intrinsifier_mips.cc ('k') | runtime/vm/log.cc » ('j') | runtime/vm/profiler_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/intrinsifier_x64.cc
diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc
index e3f2ca4d59b8c8608cd31aca435d573fb39a1de2..d9eb08baa9990fa73290a6f4f34b8d817715c57e 100644
--- a/runtime/vm/intrinsifier_x64.cc
+++ b/runtime/vm/intrinsifier_x64.cc
@@ -1536,11 +1536,11 @@ void Intrinsifier::ObjectRuntimeType(Assembler* assembler) {
__ LoadClassIdMayBeSmi(RCX, RAX);
// RCX: untagged cid of instance (RAX).
+ __ cmpq(RCX, Immediate(kClosureCid));
+ __ j(EQUAL, &fall_through, Assembler::kNearJump); // Instance is a closure.
+
__ LoadClassById(RDI, RCX);
// RDI: class of instance (RAX).
- __ movq(RCX, FieldAddress(RDI, Class::signature_function_offset()));
- __ CompareObject(RCX, Object::null_object());
- __ j(NOT_EQUAL, &fall_through, Assembler::kNearJump);
__ movzxw(RCX, FieldAddress(RDI, Class::num_type_arguments_offset()));
__ cmpq(RCX, Immediate(0));
« runtime/observatory/tests/service/graph_test.dart ('K') | « runtime/vm/intrinsifier_mips.cc ('k') | runtime/vm/log.cc » ('j') | runtime/vm/profiler_test.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698