Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1584133002: Polish icecc instructions (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Polish icecc instructions Be more specific about when you have to use system linker with icecc. It seems to have broke with a glibc 2.21 upgrade. Committed: https://crrev.com/fdc89d816f94bffaaaea2a2e72992a45e5ed7178 Cr-Commit-Position: refs/heads/master@{#369432}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add bug link #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M docs/linux_faster_builds.md View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
davve
PTAL
4 years, 11 months ago (2016-01-14 08:21:55 UTC) #2
Nico
lgtm https://codereview.chromium.org/1584133002/diff/1/docs/linux_faster_builds.md File docs/linux_faster_builds.md (right): https://codereview.chromium.org/1584133002/diff/1/docs/linux_faster_builds.md#newcode49 docs/linux_faster_builds.md:49: Using the system linker is necessary when using ...
4 years, 11 months ago (2016-01-14 15:15:18 UTC) #3
Nico
Ah, you answered that in the other review. Maybe add a link to the bug ...
4 years, 11 months ago (2016-01-14 15:15:58 UTC) #4
davve
On 2016/01/14 15:15:58, Nico (afk today Thu Jan 14) wrote: > Ah, you answered that ...
4 years, 11 months ago (2016-01-14 16:08:52 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1584133002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1584133002/20001
4 years, 11 months ago (2016-01-14 16:10:11 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-14 16:40:46 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 16:43:02 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/fdc89d816f94bffaaaea2a2e72992a45e5ed7178
Cr-Commit-Position: refs/heads/master@{#369432}

Powered by Google App Engine
This is Rietveld 408576698