Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7285)

Unified Diff: chrome/renderer/resources/extensions/tabs_custom_bindings.js

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/resources/extensions/tabs_custom_bindings.js
diff --git a/chrome/renderer/resources/extensions/tabs_custom_bindings.js b/chrome/renderer/resources/extensions/tabs_custom_bindings.js
index 0d7c405ef2928f39aef27023837649daba5c9b0d..bd2086c038a67ede7e7acba525067aa0865b4ada 100644
--- a/chrome/renderer/resources/extensions/tabs_custom_bindings.js
+++ b/chrome/renderer/resources/extensions/tabs_custom_bindings.js
@@ -6,12 +6,11 @@
var binding = require('binding').Binding.create('tabs');
+var miscBindings = require('miscellaneous_bindings');
var tabsNatives = requireNative('tabs');
var OpenChannelToTab = tabsNatives.OpenChannelToTab;
var sendRequestIsDisabled = requireNative('process').IsSendRequestDisabled();
-var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();
-
binding.registerCustomHook(function(bindingsAPI, extensionId) {
var apiFunctions = bindingsAPI.apiFunctions;
var tabs = bindingsAPI.compiledApi;
@@ -22,21 +21,21 @@ binding.registerCustomHook(function(bindingsAPI, extensionId) {
name = connectInfo.name || name;
}
var portId = OpenChannelToTab(tabId, extensionId, name);
- return chromeHidden.Port.createPort(portId, name);
+ return miscBindings.createPort(portId, name);
});
apiFunctions.setHandleRequest('sendRequest',
function(tabId, request, responseCallback) {
if (sendRequestIsDisabled)
throw new Error(sendRequestIsDisabled);
- var port = tabs.connect(tabId, {name: chromeHidden.kRequestChannel});
- chromeHidden.Port.sendMessageImpl(port, request, responseCallback);
+ var port = tabs.connect(tabId, {name: miscBindings.kRequestChannel});
+ miscBindings.sendMessageImpl(port, request, responseCallback);
});
apiFunctions.setHandleRequest('sendMessage',
function(tabId, message, responseCallback) {
- var port = tabs.connect(tabId, {name: chromeHidden.kMessageChannel});
- chromeHidden.Port.sendMessageImpl(port, message, responseCallback);
+ var port = tabs.connect(tabId, {name: miscBindings.kMessageChannel});
+ miscBindings.sendMessageImpl(port, message, responseCallback);
});
});

Powered by Google App Engine
This is Rietveld 408576698