Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1058)

Unified Diff: chrome/renderer/extensions/miscellaneous_bindings.h

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/miscellaneous_bindings.h
diff --git a/chrome/renderer/extensions/miscellaneous_bindings.h b/chrome/renderer/extensions/miscellaneous_bindings.h
index 33bb15ee37d1690c229bb860eca5b69a70d64427..97fee368eecdd648d70c7a7d17d6a11cbe52fe96 100644
--- a/chrome/renderer/extensions/miscellaneous_bindings.h
+++ b/chrome/renderer/extensions/miscellaneous_bindings.h
@@ -11,6 +11,7 @@
namespace base {
class DictionaryValue;
+class ListValue;
}
namespace content {
@@ -36,9 +37,9 @@ class MiscellaneousBindings {
static ChromeV8Extension* Get(Dispatcher* dispatcher,
v8::Handle<v8::Context> context);
- // Dispatches the Port.onConnect content script messaging event to some
- // contexts in |contexts|. If |restrict_to_render_view| is specified, only
- // contexts in that render view will receive the message.
+ // Dispatches the onConnect content script messaging event to some contexts
+ // in |contexts|. If |restrict_to_render_view| is specified, only contexts in
+ // that render view will receive the message.
static void DispatchOnConnect(
const ChromeV8ContextSet::ContextSet& contexts,
int target_port_id,
@@ -55,11 +56,10 @@ class MiscellaneousBindings {
static void DeliverMessage(
const ChromeV8ContextSet::ContextSet& context_set,
int target_port_id,
- const std::string& message,
+ const base::ListValue& message,
content::RenderView* restrict_to_render_view);
- // Dispatches the Port.onDisconnect event in response to the channel being
- // closed.
+ // Dispatches the onDisconnect event in response to the channel being closed.
static void DispatchOnDisconnect(
const ChromeV8ContextSet::ContextSet& context_set,
int port_id,
« no previous file with comments | « chrome/renderer/extensions/extension_helper.cc ('k') | chrome/renderer/extensions/miscellaneous_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698