Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5116)

Unified Diff: chrome/renderer/extensions/app_bindings.cc

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/extension_messages.h ('k') | chrome/renderer/extensions/chrome_v8_context.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/app_bindings.cc
diff --git a/chrome/renderer/extensions/app_bindings.cc b/chrome/renderer/extensions/app_bindings.cc
index b036bb230662d19054190de98ed067c8dfa9bb02..ab2dd936cfed5defab91aa9ac9cae3fc8f0a124b 100644
--- a/chrome/renderer/extensions/app_bindings.cc
+++ b/chrome/renderer/extensions/app_bindings.cc
@@ -200,11 +200,12 @@ void AppBindings::OnAppInstallStateResponse(
const std::string& state, int callback_id) {
v8::HandleScope handle_scope;
v8::Context::Scope context_scope(context_->v8_context());
- v8::Handle<v8::Value> argv[2];
- argv[0] = v8::String::New(state.c_str());
- argv[1] = v8::Integer::New(callback_id);
- CHECK(context_->CallChromeHiddenMethod("app.onInstallStateResponse",
- arraysize(argv), argv, NULL));
+ v8::Handle<v8::Value> argv[] = {
+ v8::String::New(state.c_str()),
+ v8::Integer::New(callback_id)
+ };
+ context_->module_system()->CallModuleMethod(
+ "app", "onInstallStateResponse", arraysize(argv), argv);
}
} // namespace extensions
« no previous file with comments | « chrome/common/extensions/extension_messages.h ('k') | chrome/renderer/extensions/chrome_v8_context.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698