Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3393)

Unified Diff: chrome/common/extensions/extension_messages.h

Issue 15841013: Make miscellaneous_bindings and event_bindings Required as needed. Previously (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/extensions/api/test.json ('k') | chrome/renderer/extensions/app_bindings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/extension_messages.h
diff --git a/chrome/common/extensions/extension_messages.h b/chrome/common/extensions/extension_messages.h
index b4eaee2f90e4574f4f5b8fe4d73736e487d7c90f..ad70a8aa1cbdfd36dec2ddc7f838b603bbb2a757 100644
--- a/chrome/common/extensions/extension_messages.h
+++ b/chrome/common/extensions/extension_messages.h
@@ -290,15 +290,17 @@ IPC_MESSAGE_ROUTED4(ExtensionMsg_Response,
ListValue /* response wrapper (see comment above) */,
std::string /* error */)
-// This message is optionally routed. If used as a control message, it
-// will call a javascript function in every registered context in the
-// target process. If routed, it will be restricted to the contexts that
-// are part of the target RenderView.
+// This message is optionally routed. If used as a control message, it will
+// call a javascript function |function_name| from module |module_name| in
+// every registered context in the target process. If routed, it will be
+// restricted to the contexts that are part of the target RenderView.
+//
// If |extension_id| is non-empty, the function will be invoked only in
// contexts owned by the extension. |args| is a list of primitive Value types
// that are passed to the function.
-IPC_MESSAGE_ROUTED4(ExtensionMsg_MessageInvoke,
+IPC_MESSAGE_ROUTED5(ExtensionMsg_MessageInvoke,
std::string /* extension_id */,
+ std::string /* module_name */,
std::string /* function_name */,
ListValue /* args */,
bool /* delivered as part of a user gesture */)
@@ -409,7 +411,7 @@ IPC_MESSAGE_ROUTED2(ExtensionMsg_GetAppInstallStateResponse,
std::string /* state */,
int32 /* callback_id */)
-// Dispatch the Port.onConnect event for message channels.
+// Dispatch the onConnect event for message channels.
IPC_MESSAGE_ROUTED4(ExtensionMsg_DispatchOnConnect,
int /* target_port_id */,
std::string /* channel_name */,
@@ -419,9 +421,9 @@ IPC_MESSAGE_ROUTED4(ExtensionMsg_DispatchOnConnect,
// Deliver a message sent with ExtensionHostMsg_PostMessage.
IPC_MESSAGE_ROUTED2(ExtensionMsg_DeliverMessage,
int /* target_port_id */,
- std::string /* message */)
+ ListValue /* message arguments, a 0-or-1 length list */)
-// Dispatch the Port.onDisconnect event for message channels.
+// Dispatch the onDisconnect event for message channels.
IPC_MESSAGE_ROUTED2(ExtensionMsg_DispatchOnDisconnect,
int /* port_id */,
std::string /* error_message */)
@@ -529,7 +531,7 @@ IPC_SYNC_MESSAGE_CONTROL4_1(ExtensionHostMsg_OpenChannelToTab,
// by ViewHostMsg_OpenChannelTo*.
IPC_MESSAGE_ROUTED2(ExtensionHostMsg_PostMessage,
int /* port_id */,
- std::string /* message */)
+ ListValue /* message arguments, a 0-or-1 length list */)
// Send a message to an extension process. The handle is the value returned
// by ViewHostMsg_OpenChannelTo*.
« no previous file with comments | « chrome/common/extensions/api/test.json ('k') | chrome/renderer/extensions/app_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698