Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4091)

Unified Diff: chrome/browser/ui/views/find_bar_view.h

Issue 15841009: Delays find-in-page until IME composition is committed. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed so it works with NativeTextFieldWin as it did. Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/ui/views/find_bar_view.cc » ('j') | chrome/browser/ui/views/find_bar_view.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/find_bar_view.h
diff --git a/chrome/browser/ui/views/find_bar_view.h b/chrome/browser/ui/views/find_bar_view.h
index 564d298ccea77dbbf724edd32170a1d9061a6cc2..99d10f5681301691baa5be048456470b570fb187 100644
--- a/chrome/browser/ui/views/find_bar_view.h
+++ b/chrome/browser/ui/views/find_bar_view.h
@@ -80,10 +80,15 @@ class FindBarView : public DropdownBarView,
const string16& new_contents) OVERRIDE;
virtual bool HandleKeyEvent(views::Textfield* sender,
const ui::KeyEvent& key_event) OVERRIDE;
+ virtual void OnAfterUserAction(views::Textfield* sender) OVERRIDE;
virtual void OnAfterCutOrCopy() OVERRIDE;
+ virtual void OnAfterPaste() OVERRIDE;
private:
- // Update the appearance for the match count label.
+ // Starts finding |sender->text()|. If the text is empty, stops finding.
+ void DoFinding(views::Textfield* sender);
msw 2013/06/04 01:30:23 This function only uses |sender| for its text, sen
Yuki 2013/06/04 03:35:04 Done.
+
+ // Updates the appearance for the match count label.
void UpdateMatchCountAppearance(bool no_match);
// views::View:
@@ -133,6 +138,10 @@ class FindBarView : public DropdownBarView,
// between us and the WebContentsView.
FindBarHost* find_bar_host() const;
+ // Used to detect if the input text, not including the IME composition text,
+ // has changed or not.
+ string16 last_searched_text_;
+
// The controls in the window.
SearchTextfieldView* find_text_;
views::Label* match_count_text_;
« no previous file with comments | « no previous file | chrome/browser/ui/views/find_bar_view.cc » ('j') | chrome/browser/ui/views/find_bar_view.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698