Delays find-in-page until IME composition is committed.

ui/views/controls/textfield/native_textfield_views.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/controls/textfield/native_textfield_views.h"
 
 #include <algorithm>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 1379 matching lines @@
   const string16 original_text = GetText();
   const bool success = model_->Paste();
 
   if (success) {
     // As Paste is handled in model_->Paste(), the RenderText may contain
     // upper case characters. This is not consistent with other places
     // which keeps RenderText only containing lower case characters.
     string16 new_text = GetTextForDisplay(GetText());
     model_->SetText(new_text);
 
-    // Calls TextfieldController::ContentsChanged() explicitly if the paste
-    // action did not change the content at all. See http://crbug.com/79002
-    if (new_text == original_text) {
-      TextfieldController* controller = textfield_->GetController();
-      if (controller)
-        controller->ContentsChanged(textfield_, textfield_->text());
-    }
+    TextfieldController* controller = textfield_->GetController();

[msw, 2013/06/04 01:30:23]

nit: you can remove |controller|, or use assignment in the conditional if you
want; strive for consistency in your own code and with surrounding code.

[Yuki, 2013/06/04 03:35:04]

Thanks for the comment.
I'm not sure about our policy, and I wanted to keep consistency in each file,
not consistency on my side.  native_textfield_views.cc is written in this style
(separate assignment to |controller|), and native_textfield_win.cc is written in
the style of "assignment in conditional".  I thought it's better to keep the
consistency in each file.

+    if (controller)
+      controller->OnAfterPaste();
   }
   return success;
 }
 
 void NativeTextfieldViews::TrackMouseClicks(const ui::MouseEvent& event) {
   if (event.IsOnlyLeftMouseButton()) {
     base::TimeDelta time_delta = event.time_stamp() - last_click_time_;
     if (time_delta.InMilliseconds() <= GetDoubleClickInterval() &&
         !ExceededDragThresholdFromLastClickLocation(event)) {
       aggregated_clicks_ = (aggregated_clicks_ + 1) % 3;
@@ skipping 65 matching lines @@
 
 void NativeTextfieldViews::PlatformGestureEventHandling(
     const ui::GestureEvent* event) {
 #if defined(OS_WIN) && defined(USE_AURA)
   if (event->type() == ui::ET_GESTURE_TAP_DOWN && !textfield_->read_only())
     base::win::DisplayVirtualKeyboard();
 #endif
 }
 
 }  // namespace views