Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 15841004: [Binding] Support primitive type for union member (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/V8TestInterface.cpp
diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp
index de3de4005e08d523cf4b871ca3b6383d02bc7dc4..33ffe66524778d7b5f4a19118a1131cb042d54aa 100644
--- a/Source/bindings/tests/results/V8TestInterface.cpp
+++ b/Source/bindings/tests/results/V8TestInterface.cpp
@@ -532,12 +532,14 @@ v8::Handle<v8::Value> V8TestInterface::namedPropertyGetter(v8::Local<v8::String>
ASSERT(V8DOMWrapper::maybeDOMWrapper(info.Holder()));
TestInterface* collection = toNative(info.Holder());
AtomicString propertyName = toWebCoreAtomicString(name);
+ bool element0Enabled = false;
RefPtr<Node> element0;
+ bool element1Enabled = false;
RefPtr<NodeList> element1;
- collection->getItem(propertyName, element0, element1);
- if (!!element0)
+ collection->getItem(propertyName, element0Enabled, element0, element1Enabled, element1);
+ if (element0Enabled && !!element0)
kojih 2013/05/23 09:23:09 (copied from https://codereview.chromium.org/15724
return toV8Fast(element0.release(), info, collection);
- if (!!element1)
+ if (element1Enabled && !!element1)
return toV8Fast(element1.release(), info, collection);
return v8Undefined();
}

Powered by Google App Engine
This is Rietveld 408576698