Chromium Code Reviews
Help | Chromium Project | Sign in
(168)

Issue 1584008: Let LiveEdit accept a full new script source (rather than diff) (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 12 months ago by Peter Rybin
Modified:
3 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

Let LiveEdit accept a full new script source (rather than diff) Committed: http://code.google.com/p/v8/source/detail?r=4338

Patch Set 1 #

Patch Set 2 : clean up #

Total comments: 4

Patch Set 3 : follow codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+155 lines, -10 lines) Patch
M src/debug-debugger.js View 1 2 2 chunks +25 lines, -10 lines 0 comments Download
M src/liveedit-debugger.js View 1 1 chunk +83 lines, -0 lines 0 comments Download
A test/mjsunit/debug-liveedit-newsource.js View 1 chunk +47 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Peter Rybin
4 years, 12 months ago (2010-04-01 19:20:10 UTC) #1
mnaganov (OOO til Apr 9)
LGTM http://codereview.chromium.org/1584008/diff/2001/3001 File src/debug-debugger.js (right): http://codereview.chromium.org/1584008/diff/2001/3001#newcode2008 src/debug-debugger.js:2008: invocation(); nit: alignment http://codereview.chromium.org/1584008/diff/2001/3002 File src/liveedit-debugger.js (right): http://codereview.chromium.org/1584008/diff/2001/3002#newcode446 ...
4 years, 12 months ago (2010-04-02 09:05:55 UTC) #2
Peter Rybin
4 years, 12 months ago (2010-04-02 10:14:58 UTC) #3
http://codereview.chromium.org/1584008/diff/2001/3001
File src/debug-debugger.js (right):

http://codereview.chromium.org/1584008/diff/2001/3001#newcode2008
src/debug-debugger.js:2008: invocation();
On 2010/04/02 09:05:55, Michail Naganov wrote:
> nit: alignment

Done.

http://codereview.chromium.org/1584008/diff/2001/3002
File src/liveedit-debugger.js (right):

http://codereview.chromium.org/1584008/diff/2001/3002#newcode446
src/liveedit-debugger.js:446: new_source.substring(diff.change_pos,
diff.change_pos + diff.new_len),
On 2010/04/02 09:05:55, Michail Naganov wrote:
> nit: you could use 'substr' method, which accepts length as its second
argument.

I thought this is not strictly standard.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ecdb341-tainted