Re-enable Dart_Api Timeline tracing

Re-enable Dart_Api Timeline tracing

BUG=
R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/e06ad0b01cdf0dec5b6778922d08bfcc2c08312c

[Cutch, 2016-01-13 21:27:57]

Description was changed from

==========
Re-enable Dart_Api Timeline tracing

BUG=
==========

to

==========
Re-enable Dart_Api Timeline tracing

BUG=
==========

[Cutch, 2016-01-13 21:27:57]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com

[Florian Schneider, 2016-01-15 15:48:26]

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:80: #if 1
Remove the #if statement?

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:107: delete recorder_;
Make sure that the deletion of recorder_ safe here? Maybe it can also have
static lifetime?

[Cutch, 2016-01-15 17:35:49]

PTAL

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/dart_api_impl.cc
File runtime/vm/dart_api_impl.cc (right):

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/dart_api_impl.cc...
runtime/vm/dart_api_impl.cc:80: #if 1
On 2016/01/15 15:48:26, Florian Schneider wrote:
> Remove the #if statement?

Done.

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/timeline.cc
File runtime/vm/timeline.cc (right):

https://codereview.chromium.org/1584003002/diff/1/runtime/vm/timeline.cc#newc...
runtime/vm/timeline.cc:107: delete recorder_;
On 2016/01/15 15:48:26, Florian Schneider wrote:
> Make sure that the deletion of recorder_ safe here? Maybe it can also have
> static lifetime?

It can't have a static lifetime because there are multiple implementations of
it. Nothing will touch the recorder after the streams are disabled. Also, note
that all isolates have stopped running before this code runs.

[Florian Schneider, 2016-01-15 17:41:02]

lgtm

[Cutch, 2016-01-15 21:38:06]

Description was changed from

==========
Re-enable Dart_Api Timeline tracing

BUG=
==========

to

==========
Re-enable Dart_Api Timeline tracing

BUG=
R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e06ad0b01cdf0dec5b6778922d08bfcc2c08312c
==========

[Cutch, 2016-01-15 21:38:07]

Committed patchset #2 (id:20001) manually as
e06ad0b01cdf0dec5b6778922d08bfcc2c08312c (presubmit successful).