Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issue 1583993005: dart2js cps: Improve constant folding of equality operators. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
Reviewers:
sra1
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Improve constant folding of equality operators. Previously we would only fold comparisons between primitive constants, missing out on e.g. the list sentinel comparisons. BUG= R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/fb0330df46cb316a3b2d1fc751cf1dd80cac156d

Patch Set 1 #

Patch Set 2 : Update status files and unit tests #

Patch Set 3 : Update unit test after rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -26 lines) Patch
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +23 lines, -26 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
asgerf
4 years, 11 months ago (2016-01-14 21:07:37 UTC) #4
sra1
lgtm
4 years, 11 months ago (2016-01-14 21:40:28 UTC) #5
asgerf
4 years, 11 months ago (2016-01-14 22:01:25 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
fb0330df46cb316a3b2d1fc751cf1dd80cac156d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698