Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___memcheck.json

Issue 1583933006: V8 Buildbot: Let leak checker use the v8-side wrapper. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___memcheck.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___memcheck_no_errors.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___memcheck.json
similarity index 83%
rename from scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___memcheck_no_errors.json
rename to scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___memcheck.json
index c387bbc18299db5442725e1cfb919275b1ad91e5..3825f2baace39000af249bc608d6831b85080ad2 100644
--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux___memcheck_no_errors.json
+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___memcheck.json
@@ -7,11 +7,11 @@
"--master",
"client.v8",
"--builder",
- "V8 Linux - memcheck",
+ "V8 Linux64 - memcheck",
"--slave",
"TestSlavename",
"--spec",
- "cache_dir = None\nsolutions = [{'custom_vars': {'chromium_trunk': 'svn://svn-mirror.golo.chromium.org/chrome/trunk'}, 'deps_file': 'DEPS', 'managed': True, 'name': 'v8', 'url': 'https://chromium.googlesource.com/v8/v8'}]",
+ "cache_dir = None\nsolutions = [{'custom_deps': {'v8/third_party/valgrind': 'https://chromium.googlesource.com/chromium/deps/valgrind/binaries.git'}, 'custom_vars': {'chromium_trunk': 'svn://svn-mirror.golo.chromium.org/chrome/trunk'}, 'deps_file': 'DEPS', 'managed': True, 'name': 'v8', 'url': 'https://chromium.googlesource.com/v8/v8'}]",
"--root",
"v8",
"--revision_mapping_file",
@@ -58,7 +58,7 @@
],
"cwd": "[SLAVE_BUILD]",
"env": {
- "GYP_DEFINES": "target_arch=ia32 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=ia32"
+ "GYP_DEFINES": "target_arch=x64 v8_enable_slow_dchecks=1 v8_optimized_debug=1 v8_target_arch=x64"
},
"name": "gclient runhooks"
},
@@ -98,7 +98,7 @@
"--target",
"Debug",
"--build-url",
- "gs://chromium-v8/v8-linux-dbg",
+ "gs://chromium-v8/v8-linux64-dbg",
"--src-dir",
"v8",
"--master-name",
@@ -111,21 +111,15 @@
},
{
"cmd": [
- "valgrind",
- "--leak-check=full",
- "--show-reachable=yes",
- "--num-callers=20",
+ "python",
+ "-u",
+ "[SLAVE_BUILD]/v8/tools/run-valgrind.py",
"out/Debug/d8",
"-e",
- "\"print(1+2)\""
+ "print(1+2)"
],
"cwd": "[SLAVE_BUILD]/v8",
- "name": "Simple Leak Check",
- "stderr": "/path/to/tmp/",
- "~followup_annotations": [
- "@@@STEP_LOG_LINE@stderr@no leaks are possible@@@",
- "@@@STEP_LOG_END@stderr@@@"
- ]
+ "name": "Simple Leak Check"
},
{
"name": "$result",

Powered by Google App Engine
This is Rietveld 408576698