Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1583923002: remove CreateLightingFilter from SkColorFilter (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
djsollen, f(malita)
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove CreateLightingFilter from SkColorFilter All callers have converted over to SkColorMatrixFilter BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1583923002 Committed: https://skia.googlesource.com/skia/+/fa2b3a376d93e1d611e48c3c2f31ec3198d53600

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M include/core/SkColorFilter.h View 1 chunk +0 lines, -3 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
reed1
4 years, 11 months ago (2016-01-13 18:20:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583923002/1
4 years, 11 months ago (2016-01-13 18:20:26 UTC) #6
f(malita)
Assuming Android no longer needs this, LGTM.
4 years, 11 months ago (2016-01-13 18:22:07 UTC) #7
djsollen
lgtm
4 years, 11 months ago (2016-01-13 18:24:14 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-13 18:31:27 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583923002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583923002/1
4 years, 11 months ago (2016-01-13 18:42:43 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 18:43:12 UTC) #14
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/fa2b3a376d93e1d611e48c3c2f31ec3198d53600

Powered by Google App Engine
This is Rietveld 408576698