Issue 1583913003: Introduce deviceDependentMediaQueries (similar to viewportDependent).

Issue 1583913003: Introduce deviceDependentMediaQueries (similar to viewportDependent). (Closed)

Created:
4 years, 11 months ago by dgozman

Modified:
4 years, 3 months ago

Reviewers:
rune

CC:
chromium-reviews, kenneth.christiansen, Yoav Weiss, blink-reviews-style_chromium.org, blink-reviews-css, devtools-reviews_chromium.org, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Introduce deviceDependentMediaQueries (similar to viewportDependent). When DevTools mobile device emulation is on, page resize also means device size has change, and therefore device-dependent media queries should be re-evaluated similarly to viewport-dependent ones. Previous solution for this was forcing styles reset on each resize while DevTools emulation was enabled, which turned out to be very slow. Now DevToolsEmulator uses setting resizeIsDeviceSizeChange to control new behavior. BUG=540864 TEST=DeviceEmulationTest.DeviceSizeInvalidatedOnResize Committed: https://crrev.com/7cb1e690280683811b7ca034d5ac9090927a9398 Cr-Commit-Position: refs/heads/master@{#369316}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review fixes #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -24 lines)			Patch
M	third_party/WebKit/Source/core/css/MediaQueryEvaluator.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/MediaQueryEvaluator.cpp	View		4 chunks	+5 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/MediaQueryExp.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/MediaQueryExp.cpp	View	1	1 chunk	+13 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/RuleSet.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/RuleSet.cpp	View		3 chunks	+3 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/resolver/ScopedStyleResolver.cpp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	third_party/WebKit/Source/core/css/resolver/StyleResolver.h	View		2 chunks	+4 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp	View		3 chunks	+18 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/FrameView.cpp	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	third_party/WebKit/Source/core/frame/Settings.in	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/DevToolsEmulator.cpp	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	third_party/WebKit/Source/web/WebViewImpl.cpp	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 20 (9 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583913003/1

4 years, 11 months ago (2016-01-13 18:34:39 UTC) #2

dgozman

Hi, Could you please take a look? This drastically speeds up important DevTools usecase of ...

4 years, 11 months ago (2016-01-13 20:19:17 UTC) #4

rune

Looks great! One issue with missing aspect-ratio queries. Otherwise, Source/core lgtm. I was wondering how ...

4 years, 11 months ago (2016-01-13 22:17:48 UTC) #5

dgozman

Thank you for review! On 2016/01/13 22:17:48, rune wrote: > Looks great! > > One ...

4 years, 11 months ago (2016-01-13 23:30:54 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583913003/20001

4 years, 11 months ago (2016-01-13 23:34:59 UTC) #9

rune

On 2016/01/13 23:30:54, dgozman wrote: > On 2016/01/13 22:17:48, rune wrote: > > I was ...

4 years, 11 months ago (2016-01-13 23:50:45 UTC) #10

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583913003/20001

4 years, 11 months ago (2016-01-14 00:29:42 UTC) #13

commit-bot: I haz the power

Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...

4 years, 11 months ago (2016-01-14 01:40:58 UTC) #15

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583913003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583913003/20001

4 years, 11 months ago (2016-01-14 02:18:28 UTC) #17

commit-bot: I haz the power

Description was changed from ========== Introduce deviceDependentMediaQueries (similar to viewportDependent). When DevTools mobile device emulation ...

4 years, 11 months ago (2016-01-14 03:56:57 UTC) #19

commit-bot: I haz the power

4 years, 11 months ago (2016-01-14 03:56:58 UTC) #20

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/7cb1e690280683811b7ca034d5ac9090927a9398
Cr-Commit-Position: refs/heads/master@{#369316}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages