Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 1583903002: PPC: [builtins] Migrate Number constructor similar to String constructor. (Closed)

Created:
4 years, 11 months ago by MTBrandyberry
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [builtins] Migrate Number constructor similar to String constructor. Port 322ffda30dfefd7101a2bd93e33563cf19fbb022 Original commit message: Also migrate the Number constructor to a native builtin, using the same mechanism already used by the String constructor. Otherwise just parsing and compiling the Number constructor to optimized code already eats 2ms on desktop for no good reason, and the resulting optimized code is not even close to awesome. Drive-by-fix: Use correct context for the [[Construct]] case of the String constructor as well, and share some code with it. R=bmeurer@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com BUG= Committed: https://crrev.com/26a52ed477e101d78624b0b872823654a7655368 Cr-Commit-Position: refs/heads/master@{#33272}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+142 lines, -24 lines) Patch
M src/ppc/builtins-ppc.cc View 4 chunks +114 lines, -24 lines 0 comments Download
M src/ppc/macro-assembler-ppc.h View 1 chunk +6 lines, -0 lines 0 comments Download
M src/ppc/macro-assembler-ppc.cc View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
MTBrandyberry
4 years, 11 months ago (2016-01-13 17:34:43 UTC) #1
michael_dawson
On 2016/01/13 17:34:43, mtbrandyberry wrote: lgtm
4 years, 11 months ago (2016-01-13 17:58:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583903002/1
4 years, 11 months ago (2016-01-13 19:00:37 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-13 19:30:11 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-13 19:31:11 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/26a52ed477e101d78624b0b872823654a7655368
Cr-Commit-Position: refs/heads/master@{#33272}

Powered by Google App Engine
This is Rietveld 408576698