Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 1583863003: [parser] reject AssignmentElements with non-ASSIGN initializer ops (Closed)

Created:
4 years, 11 months ago by caitp (gmail)
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[parser] reject AssignmentElements with non-ASSIGN initializer ops When parsing a pattern element with an assignment operator that is not Token::ASSIGN, record a pattern error to indicate the invalid assignment target. BUG=v8:811, v8:4666 LOG=N R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org Committed: https://crrev.com/d19e3a21d6f2785280d84d70a7c7de89e391a949 Cr-Commit-Position: refs/heads/master@{#33279}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
M src/parsing/parser-base.h View 1 chunk +6 lines, -0 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
caitp (gmail)
quick fix for the fuzzer error --- I'll do a followup to unify paths with ...
4 years, 11 months ago (2016-01-14 02:30:22 UTC) #1
adamk
lgtm
4 years, 11 months ago (2016-01-14 02:32:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583863003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583863003/1
4 years, 11 months ago (2016-01-14 02:34:30 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 03:08:46 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 03:09:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d19e3a21d6f2785280d84d70a7c7de89e391a949
Cr-Commit-Position: refs/heads/master@{#33279}

Powered by Google App Engine
This is Rietveld 408576698