Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 15838015: Revert 202787 "Remove unnecessary ui::CompositorTestSupport" (Closed)

Created:
7 years, 6 months ago by kinuko
Modified:
7 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 202787 "Remove unnecessary ui::CompositorTestSupport" Suspected to break Linux ChromeOS build http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Full/builds/19953/steps/compile/logs/stdio obj/ui/snapshot/test/snapshot_unittests.run_all_unittests.o:run_all_unittests.cc:function main:error: undefined reference to 'ui::test::CompositorTestSuite::CompositorTestSuite(int, char**)' obj/ui/snapshot/test/snapshot_unittests.run_all_unittests.o:run_all_unittests.cc:function main:error: undefined reference to 'ui::test::CompositorTestSuite::~CompositorTestSuite()' > Remove unnecessary ui::CompositorTestSupport > > The ui::CompositorTestSupport class existed to initialize WebKit since > ui::Compositor depends on cc which used to depend on WebKit being initialized > to function properly. cc no longer has this requirement, so this class is > unnecessary. > > R=piman, sky > > Review URL: https://chromiumcodereview.appspot.com/14744016 TBR=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202790

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -12 lines) Patch
M trunk/src/ash/ash.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/ash/shell/content_client/shell_browser_main_parts.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ash/test/test_suite.cc View 2 chunks +3 lines, -0 lines 0 comments Download
MM trunk/src/ash/wm/session_state_controller_impl2_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/chrome_tests_unit.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/test/base/view_event_test_base.cc View 3 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/ui/app_list/app_list.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/aura/bench/bench_main.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/demo/demo_main.cc View 3 chunks +4 lines, -0 lines 0 comments Download
M trunk/src/ui/aura/test/test_suite.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/ui/compositor/compositor.gyp View 2 chunks +15 lines, -13 lines 0 comments Download
A + trunk/src/ui/compositor/test/compositor_test_support.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + trunk/src/ui/compositor/test/compositor_test_support.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M trunk/src/ui/compositor/test/test_suite.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/ui/keyboard/keyboard.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/keyboard/keyboard_test_suite.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M trunk/src/ui/message_center/message_center.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/message_center/test/run_all_unittests.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/ui/snapshot/snapshot.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/ui/views/run_all_unittests.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M trunk/src/ui/views/views.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M trunk/src/webkit/support/webkit_support.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
kinuko
7 years, 6 months ago (2013-05-29 07:16:52 UTC) #1
kinuko
7 years, 6 months ago (2013-05-29 07:17:05 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r202790.

Powered by Google App Engine
This is Rietveld 408576698