Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(175)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15838011: Fix where the clear button will be drawn when adding padding to the input element. (Closed)

Created:
7 years, 7 months ago by keishi
Modified:
7 years, 6 months ago
CC:
blink-reviews, eae+blinkwatch, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears
Visibility:
Public.

Description

Fix where the clear button will be drawn when adding padding to the input element. The search-cancel-button was being drawn relative to the input element. This caused problems when adding padding. This patch fixes that. This also addresses the issue of the search-cancel-button never being drawn as NSRegularControlSize. If the font size is over 16 the search field will be NSRegularControlSize, but because setFontFromControlSize is called, the font size for the style of the cancel button becomes 13, causing it to be drawn as NSSmallControlSize. Also the cancelButtonSizes for regular size was off by one. Also the margin was on the other side when rtl. TEST=Automated. Added tests to *-appearance-basic.html. BUG=244118 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151551

Patch Set 1 #

Patch Set 2 : #

Total comments: 4

Patch Set 3 : Changed to static function, Removed pngs #

Total comments: 1

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+96 lines, -39 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 4 5 6 7 1 chunk +47 lines, -0 lines 0 comments Download
M LayoutTests/fast/css/input-search-padding-expected.txt View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M LayoutTests/fast/forms/date/date-appearance-basic.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/date/date-appearance-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/datetimelocal/datetimelocal-appearance-basic.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/month/month-appearance-basic.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/month/month-appearance-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/searchfield-heights.html View 1 chunk +3 lines, -3 lines 0 comments Download
M LayoutTests/fast/forms/time/time-appearance-basic.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/time/time-appearance-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/week/week-appearance-basic.html View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/fast/forms/week/week-appearance-basic-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M LayoutTests/platform/chromium-mac/fast/forms/searchfield-heights-expected.txt View 1 chunk +12 lines, -12 lines 0 comments Download
M Source/core/css/html.css View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderThemeChromiumMac.mm View 1 2 3 4 5 6 7 7 chunks +21 lines, -21 lines 0 comments Download

Messages

Total messages: 20 (0 generated)
keishi
7 years, 7 months ago (2013-05-27 12:30:33 UTC) #1
tkent
I checked image results. You can remove images in the patch and add tests to ...
7 years, 7 months ago (2013-05-27 22:44:50 UTC) #2
keishi
https://codereview.chromium.org/15838011/diff/6003/Source/core/rendering/RenderThemeChromiumMac.mm File Source/core/rendering/RenderThemeChromiumMac.mm (left): https://codereview.chromium.org/15838011/diff/6003/Source/core/rendering/RenderThemeChromiumMac.mm#oldcode1627 Source/core/rendering/RenderThemeChromiumMac.mm:1627: #if ENABLE(INPUT_SPEECH) On 2013/05/27 22:44:50, tkent wrote: > Is ...
7 years, 7 months ago (2013-05-28 03:21:57 UTC) #3
tkent
lgtm https://codereview.chromium.org/15838011/diff/16001/LayoutTests/fast/forms/search/search-appearance-basic.html File LayoutTests/fast/forms/search/search-appearance-basic.html (right): https://codereview.chromium.org/15838011/diff/16001/LayoutTests/fast/forms/search/search-appearance-basic.html#newcode46 LayoutTests/fast/forms/search/search-appearance-basic.html:46: <!-- speech --> We don't need to add ...
7 years, 7 months ago (2013-05-28 03:25:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/21001
7 years, 7 months ago (2013-05-28 03:45:42 UTC) #5
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-28 03:45:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/37001
7 years, 7 months ago (2013-05-28 04:59:27 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10433
7 years, 7 months ago (2013-05-28 05:49:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/49001
7 years, 7 months ago (2013-05-28 11:18:59 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10480
7 years, 7 months ago (2013-05-28 12:10:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/60001
7 years, 6 months ago (2013-05-29 02:35:10 UTC) #11
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7289
7 years, 6 months ago (2013-05-29 05:55:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/60001
7 years, 6 months ago (2013-05-29 09:07:01 UTC) #13
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7358
7 years, 6 months ago (2013-05-29 11:39:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/60001
7 years, 6 months ago (2013-05-30 05:43:26 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7649
7 years, 6 months ago (2013-05-30 08:52:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/60001
7 years, 6 months ago (2013-05-31 04:35:14 UTC) #17
commit-bot: I haz the power
Retried try job too often on win_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout_rel&number=7982
7 years, 6 months ago (2013-05-31 07:35:30 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/keishi@chromium.org/15838011/60001
7 years, 6 months ago (2013-05-31 12:39:04 UTC) #19
commit-bot: I haz the power
7 years, 6 months ago (2013-05-31 13:06:49 UTC) #20
Message was sent while issue was closed. 
Change committed as 151551

Powered by Google App Engine
This is Rietveld 408576698