[Interpreter] Adds support for variable/function declarations in lookup slots.

test/cctest/interpreter/test-bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-array-iterator.h"
 #include "src/interpreter/bytecode-generator.h"
 #include "src/interpreter/interpreter.h"
@@ skipping 6210 matching lines @@
            B(Return),                            //
        },
        1,
        {"x"}},
   };
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
     std::string script = std::string(function_prologue) +
                          std::string(snippets[i].code_snippet) +
                          std::string(function_epilogue);
-    // TODO(mythria): use * as filter when function declarations are supported
-    // inside eval.
     Handle<BytecodeArray> bytecode_array =
-        helper.MakeBytecode(script.c_str(), "t", "f");
+        helper.MakeBytecode(script.c_str(), "*", "f");
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 
 TEST(LookupSlotWideInEval) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
 
   const char* function_prologue =
@@ skipping 73 matching lines @@
        },
        257,
        {REPEAT_256(COMMA, InstanceType::HEAP_NUMBER_TYPE),
         InstanceType::ONE_BYTE_INTERNALIZED_STRING_TYPE}},
   };
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
     std::string script = std::string(function_prologue) +
                          std::string(snippets[i].code_snippet) +
                          std::string(function_epilogue);
-    // TODO(mythria): use * as filter when function declarations are supported
-    // inside eval.
     Handle<BytecodeArray> bytecode_array =
-        helper.MakeBytecode(script.c_str(), "t", "f");
+        helper.MakeBytecode(script.c_str(), "*", "f");
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 
+TEST(LookupSlotVariableDecl) {
+  InitializedHandleScope handle_scope;
+  BytecodeGeneratorHelper helper;

[rmcilroy, 2016/01/14 11:21:12]

no need for these variables (I thought the compiler would complain about these
unused variables). In fact, there is no need for the empty test at all - just
add a TODO without an empty test function.

[mythria, 2016/01/15 11:27:04]

Done.

+  // TODO(mythria): tests for variable/function declaration in lookup slots.
+}
+
+
 TEST(DeleteLookupSlotInEval) {
   InitializedHandleScope handle_scope;
   BytecodeGeneratorHelper helper;
 
   const char* function_prologue = "var f;"
                                   "var x = 1;"
                                   "z = 10;"
                                   "function f1() {"
                                   "  var y;"
                                   "  eval(\"function t() {";
@@ skipping 34 matching lines @@
        },
        1,
        {"z"}},
   };
 
   for (size_t i = 0; i < arraysize(snippets); i++) {
     std::string script = std::string(function_prologue) +
                          std::string(snippets[i].code_snippet) +
                          std::string(function_epilogue);
     Handle<BytecodeArray> bytecode_array =
-        helper.MakeBytecode(script.c_str(), "t", "f");
+        helper.MakeBytecode(script.c_str(), "*", "f");
     CheckBytecodeArrayEqual(snippets[i], bytecode_array);
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8