Use IndentTextOrNot instead of a bool

Use IndentTextOrNot instead of a bool

BUG=568851
Committed: https://crrev.com/4827508d33eda3f39fa999e53d11998695f45c4f
Cr-Commit-Position: refs/heads/master@{#369795}

[rhogan, 2016-01-13 18:46:45]

robhogan@gmail.com changed reviewers:
+ jchaffraix@chromium.org

[Julien - ping for review, 2016-01-14 16:50:34]

lgtm, I have a slight preference for using |applyTextIndent| for the new
variables but |textIndent| works too so it's a nit.

https://codereview.chromium.org/1583783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp (right):

https://codereview.chromium.org/1583783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp:1967: void
LayoutBlockFlow::updateStaticInlinePositionForChild(LayoutBox& child, LayoutUnit
logicalTop, IndentTextOrNot shouldIndentText)
s/shouldIndentText/indentText/

https://codereview.chromium.org/1583783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp (right):

https://codereview.chromium.org/1583783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp:571: static void
updateLogicalInlinePositions(LayoutBlockFlow* block, LayoutUnit&
lineLogicalLeft, LayoutUnit& lineLogicalRight, LayoutUnit&
availableLogicalWidth, bool firstLine, IndentTextOrNot shouldIndentText,
LayoutUnit boxLogicalHeight)
s/shouldIndentText/indentText/ to match the rest of the code (and it's not a
boolean anymore)

https://codereview.chromium.org/1583783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/line/LineWidth.h (right):

https://codereview.chromium.org/1583783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/line/LineWidth.h:76: bool
shouldIndentText() const { return m_shouldIndentText == IndentText; }
Do we still have users of this? If so, we should probably convert them as part
of the change.

[rhogan, 2016-01-15 12:48:45]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-01-15 12:48:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
jchaffraix@chromium.org
Link to the patchset: https://codereview.chromium.org/1583783002/#ps20001
(title: "Updated")

[commit-bot: I haz the power, 2016-01-15 12:48:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583783002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583783002/20001

[commit-bot: I haz the power, 2016-01-15 12:57:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-15 12:57:51]

Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[rhogan, 2016-01-15 16:59:13]

The CQ bit was checked by robhogan@gmail.com

[rhogan, 2016-01-15 16:59:13]

The patchset sent to the CQ was uploaded after l-g-t-m from
jchaffraix@chromium.org
Link to the patchset: https://codereview.chromium.org/1583783002/#ps40001
(title: "Update")

[commit-bot: I haz the power, 2016-01-15 17:00:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583783002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583783002/40001

[commit-bot: I haz the power, 2016-01-15 18:43:34]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-15 18:44:54]

Description was changed from

==========
Use IndentTextOrNot instead of a bool

BUG=568851
==========

to

==========
Use IndentTextOrNot instead of a bool

BUG=568851

Committed: https://crrev.com/4827508d33eda3f39fa999e53d11998695f45c4f
Cr-Commit-Position: refs/heads/master@{#369795}
==========

[commit-bot: I haz the power, 2016-01-15 18:44:55]

Patchset 3 (id:??) landed as
https://crrev.com/4827508d33eda3f39fa999e53d11998695f45c4f
Cr-Commit-Position: refs/heads/master@{#369795}