Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used incons…

Support JS$ prefix for dart and fix bug where _operator_getter and the [] operator were used inconsistently. Would only impact future use cases where js APIs returned types not auto-proxied with dart:html.

Support typed JS interop classes that extend the behavior of  dart:html types in Dartium.

This theoretically enables supporting package:dom at the same time as dart:html as well as helping with
JavaScript libraries that monkey patch the dom.

Also support JS$ name prefix to resolve name conflicts with dart reserved words and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.

BUG=
R=alanknight@google.com

Committed: https://github.com/dart-lang/sdk/commit/cf7ae2e0cb2c9af91c86ee603a71d114e72905db

[Jacob, 2016-01-13 21:02:09]

jacobr@google.com changed reviewers:
+ alanknight@google.com, terry@google.com

[Jacob, 2016-01-13 21:02:09]

I was holding off on this CL until Dartium 45 landed but looks like it is needed
now as it is blocking some internal interop users.
Note: dart2js support for these features is in a separate CL.
Kudos to Alan for pointing out I should override runtimeType to avoid breaking
custom element support.

[Alan Knight, 2016-01-14 00:22:09]

lgtm

https://codereview.chromium.org/1583773003/diff/1/sdk/lib/js/dartium/js_darti...
File sdk/lib/js/dartium/js_dartium.dart (right):

https://codereview.chromium.org/1583773003/diff/1/sdk/lib/js/dartium/js_darti...
sdk/lib/js/dartium/js_dartium.dart:910: if (dartClass_instance is JSObject &&
I suppose the ship has sailed that we have them as JSObject and JsObject?

[Jacob, 2016-01-15 18:40:35]

Description was changed from

==========
Support JS$ prefix for dart and fix bug where _operator_getter and the []
operator were used inconsistently. Would only impact future use cases where js
APIs returned types not auto-proxied with dart:html.

Support typed JS interop classes that extend the behavior of  dart:html types in
Dartium.

This theoretically enables supporting package:dom at the same time as dart:html
as well as helping with
JavaScript libraries that monkey patch the dom.

Also support JS$ name prefix to resolve name conflicts with dart reserved words
and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS
Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.

BUG=
==========

to

==========
Support JS$ prefix for dart and fix bug where _operator_getter and the []
operator were used inconsistently. Would only impact future use cases where js
APIs returned types not auto-proxied with dart:html.

Support typed JS interop classes that extend the behavior of  dart:html types in
Dartium.

This theoretically enables supporting package:dom at the same time as dart:html
as well as helping with
JavaScript libraries that monkey patch the dom.

Also support JS$ name prefix to resolve name conflicts with dart reserved words
and with
dart:html libraries.
Cleanup addEventListener and friends so they are consistent with typed JS
Interop and fix
bugs in the unlikely case where multiple functions have the same identity hash.
Add checks to make it easier to catch when allowInterop is accidentally omitted
when using the new typed JavaScript interop. You will now get an exception
any time you pass a Function to JS via the new typed interop without first
calling allowInterop.

BUG=
R=alanknight@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cf7ae2e0cb2c9af91c86ee603a71d114e72905db
==========

[Jacob, 2016-01-15 18:40:36]

Committed patchset #2 (id:20001) manually as
cf7ae2e0cb2c9af91c86ee603a71d114e72905db (presubmit successful).