Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 1583713003: Reject compound selectors with unknown namespace prefixes (Closed)

Created:
4 years, 11 months ago by Timothy Loh
Modified:
4 years, 11 months ago
Reviewers:
ramya.v, rune
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reject compound selectors with unknown namespace prefixes In a previous patch, crrev.com/1e8c4674, we started rejecting selectors with unknown namespace prefixes. However the patch had a bug, where in a compound selector an unknown namespace prefix and additional components, we would ignore the elemental selector portion instead of marking the entire selector as invalid. This patch fixes this case. BUG=565611 Committed: https://crrev.com/f4bae27ff706c3cc623d1266a9c75215dbd42dc8 Cr-Commit-Position: refs/heads/master@{#369322}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/fast/css/namespaces/namespaces-invalid-prefix.xhtml View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Timothy Loh
4 years, 11 months ago (2016-01-13 06:10:08 UTC) #2
ramya.v
On 2016/01/13 06:10:08, Timothy Loh wrote: @Tim Thanks for correcting :)
4 years, 11 months ago (2016-01-13 06:35:06 UTC) #4
rune
lgtm
4 years, 11 months ago (2016-01-13 08:21:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583713003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583713003/1
4 years, 11 months ago (2016-01-14 02:05:50 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 04:21:28 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 04:22:15 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4bae27ff706c3cc623d1266a9c75215dbd42dc8
Cr-Commit-Position: refs/heads/master@{#369322}

Powered by Google App Engine
This is Rietveld 408576698