Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Issue 15837006: Make (Object.)observed Arrays use SafeRemoveArrayHoles during sort (Closed)

Created:
7 years, 7 months ago by rafaelw
Modified:
7 years, 6 months ago
Reviewers:
adamk, rossberg
CC:
v8-dev
Visibility:
Public.

Description

Make (Object.)observed Arrays use SafeRemoveArrayHoles during sort R=adamk,rossberg BUG= Committed: http://code.google.com/p/v8/source/detail?r=14847

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M src/array.js View 1 chunk +6 lines, -4 lines 0 comments Download
M src/objects.cc View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/harmony/object-observe.js View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rafaelw
7 years, 7 months ago (2013-05-23 22:19:03 UTC) #1
adamk
lgtm
7 years, 7 months ago (2013-05-23 22:51:47 UTC) #2
rafaelw
PTAL, Andreas.
7 years, 7 months ago (2013-05-28 00:17:03 UTC) #3
rossberg
lgtm
7 years, 6 months ago (2013-05-28 11:06:08 UTC) #4
rossberg
7 years, 6 months ago (2013-05-28 11:24:06 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r14847 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698