Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1583623002: dart2js inferrer: don't infer widened type when unreachable (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js inferrer: don't infer widened type when unreachable '&' and '|' were missing the case to return 'empty' if the argument was empty, causing the widened (default) type to be propagated. There are a few bitwise operations in the streams code that have better code from being slightly more precise. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/478106bce28fe6d0e7e2f34845dc66f7f7c3ca0d

Patch Set 1 #

Patch Set 2 : reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -58 lines) Patch
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 2 chunks +72 lines, -54 lines 0 comments Download

Messages

Total messages: 10 (7 generated)
sra1
4 years, 4 months ago (2016-07-27 22:22:07 UTC) #7
Siggi Cherem (dart-lang)
lgtm - this looks familiar, is this code by any chance a reapply of a ...
4 years, 4 months ago (2016-07-27 23:28:22 UTC) #8
sra1
4 years, 4 months ago (2016-07-28 00:26:09 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:100001) manually as
478106bce28fe6d0e7e2f34845dc66f7f7c3ca0d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698