Create LibraryElement.loadLibrary during resynth.

Create LibraryElement.loadLibrary during resynth.

R=paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0d8a31e0a6008b15427fd5d47cfeb13a960f7622

[Paul Berry, 2016-01-13 16:07:49]

https://codereview.chromium.org/1583613002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1583613002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:718: if (!isCoreLibrary) {
This seems like a bug.  The language spec allows `dart:core` to be imported with
a deferred import (and I just tested that it works with analyzer, the VM, and
dart2js), so I think we have to create the `loadLibrary` function for all
libraries, even `dart:core`.

https://codereview.chromium.org/1583613002/diff/1/pkg/analyzer/test/src/summa...
File pkg/analyzer/test/src/summary/resynthesize_test.dart (right):

https://codereview.chromium.org/1583613002/diff/1/pkg/analyzer/test/src/summa...
pkg/analyzer/test/src/summary/resynthesize_test.dart:81: if
(!original.isDartCore) {
Same issue here.

[scheglov, 2016-01-13 16:51:54]

PTAL

https://codereview.chromium.org/1583613002/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/resynthesize.dart (right):

https://codereview.chromium.org/1583613002/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/resynthesize.dart:718: if (!isCoreLibrary) {
On 2016/01/13 16:07:49, Paul Berry wrote:
> This seems like a bug.  The language spec allows `dart:core` to be imported
with
> a deferred import (and I just tested that it works with analyzer, the VM, and
> dart2js), so I think we have to create the `loadLibrary` function for all
> libraries, even `dart:core`.

Done.

[Paul Berry, 2016-01-13 16:53:38]

lgtm

https://codereview.chromium.org/1583613002/diff/20001/pkg/analyzer/test/gener...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/1583613002/diff/20001/pkg/analyzer/test/gener...
pkg/analyzer/test/generated/resolver_test.dart:411:
coreLibrary.createLoadLibraryFunction(context.typeProvider);
Nit: why not just loop over the libraries in elementMap.values, like we do
above?

[scheglov, 2016-01-13 17:35:41]

Description was changed from

==========
Create LibraryElement.loadLibrary during resynth.

R=paulberry@google.com
BUG=
==========

to

==========
Create LibraryElement.loadLibrary during resynth.

R=paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0d8a31e0a6008b15427fd5d47cfeb13a960f7622
==========

[scheglov, 2016-01-13 17:35:42]

Committed patchset #2 (id:20001) manually as
0d8a31e0a6008b15427fd5d47cfeb13a960f7622 (presubmit successful).