Update base/ to use WeakPtr<T>::get() instead of implicit "operator T*"

Update base/ to use WeakPtr<T>::get() instead of implicit "operator T*"

BUG=245942
TBR=ajwong@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=203782

[akalin, 2013-06-01 02:02:50]

+ajwong for bind_internals.h stuff
+darin for everything else

(may end up TBRing darin)

[akalin, 2013-06-03 18:49:57]

On 2013/06/01 02:02:50, akalin wrote:
> +ajwong for bind_internals.h stuff
> +darin for everything else
> 
> (may end up TBRing darin)

ping!

[awong, 2013-06-03 20:13:42]

Looks pretty solid, but have a few naming nits.

https://codereview.chromium.org/15836004/diff/1/base/bind_internal.h.pump
File base/bind_internal.h.pump (right):

https://codereview.chromium.org/15836004/diff/1/base/bind_internal.h.pump#new...
base/bind_internal.h.pump:289: $range ARG2 2..ARITY
Can we call this ARG_FROM_2 or maybe even something like WEAKCALL_ARG?

https://codereview.chromium.org/15836004/diff/1/base/bind_internal.h.pump#new...
base/bind_internal.h.pump:315: void($for ARG , [[A$(ARG)]])>  {
If we're going to go with ARG2, for this invocation, can we rename

  A1 -> BoundWeakPtr
  a1 -> weak_ptr

or something similar?

[akalin, 2013-06-03 21:23:46]

PTAL!

[awong, 2013-06-03 21:59:36]

LGTM

Hah...I forgot you needed the extra cruft in the pump file to support comments.
:-/

Thanks for making that work!

[akalin, 2013-06-03 22:14:34]

TBRing darin!

[akalin, 2013-06-03 22:15:44]

Committed patchset #2 manually as r203782 (presubmit successful).

[darin (slow to review), 2013-06-04 05:20:38]

LGTM