Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 1583573002: Remove unused ExtensionService::shared_module_policy_provider_. (Closed)

Created:
4 years, 11 months ago by lazyboy
Modified:
4 years, 11 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused ExtensionService::shared_module_policy_provider_. http://crrev.com/403593002 removed SharedModuleProvider definition, which shared_module_policy_provider_ would use to be instantiated with. Now this is never instantiated, nor UnregisterProvider call seems to be necessary. BUG=None Test=Clean up only CL. Committed: https://crrev.com/c39aa620b96cc605a79c81364234a5124de38a62 Cr-Commit-Position: refs/heads/master@{#369875}

Patch Set 1 #

Patch Set 2 : remove include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -5 lines) Patch
M chrome/browser/extensions/extension_service.h View 1 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
lazyboy
Noticed this today while closely looking at ExtensionService.
4 years, 11 months ago (2016-01-12 22:02:38 UTC) #5
asargent_no_longer_on_chrome
lgtm
4 years, 11 months ago (2016-01-15 18:48:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583573002/20001
4 years, 11 months ago (2016-01-15 22:26:01 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-15 23:07:50 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 23:09:03 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c39aa620b96cc605a79c81364234a5124de38a62
Cr-Commit-Position: refs/heads/master@{#369875}

Powered by Google App Engine
This is Rietveld 408576698