components/autofill/core/browser/autofill_field_unittest.cc - Issue 1583563003: [Autofill] Parse forms that have autocomplete attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_field_unittest.cc

Issue 1583563003: [Autofill] Parse forms that have autocomplete attributes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_field.cc ('k') | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | components/autofill/core/browser/form_structure.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_field_unittest.cc

diff --git a/components/autofill/core/browser/autofill_field_unittest.cc b/components/autofill/core/browser/autofill_field_unittest.cc

index 9438532822f12cf85096818eaf59bb8c70ae790e..10b1d96ce6a146dbce193be0fdc2343e90afba12 100644

--- a/components/autofill/core/browser/autofill_field_unittest.cc

+++ b/components/autofill/core/browser/autofill_field_unittest.cc

@@ -274,7 +274,7 @@ TEST(AutofillFieldTest, FillPhoneNumber) {

EXPECT_EQ(ASCIIToUTF16("555"), field.value);

// Now reset the type, and set a max-length instead.

- field.SetHtmlType(HTML_TYPE_UNKNOWN, HtmlFieldMode());

+ field.SetHtmlType(HTML_TYPE_UNSPECIFIED, HtmlFieldMode());

field.set_heuristic_type(PHONE_HOME_NUMBER);

field.max_length = 4;