[Autofill] Parse forms that have autocomplete attributes.

components/autofill/core/browser/autofill_manager_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stddef.h>
 
 #include <algorithm>
 #include <vector>
 
 #include "base/command_line.h"
@@ skipping 992 matching lines @@
   form2.fields.push_back(field);
 
   forms.clear();
   forms.push_back(form2);
   FormsSeen(forms);
   histogram_tester.ExpectUniqueSample("Autofill.UserHappiness",
                                       0 /* FORMS_LOADED */, 2);
   download_manager_->VerifyLastQueriedForms(forms);
 }
 
+// Test that no suggestions are returned for a field with an unrecognized
+// autocomplete attribute.
+TEST_F(AutofillManagerTest, GetProfileSuggestions_UnrecognizedAttribute) {
+  FormData form;
+  form.name = ASCIIToUTF16("MyForm");
+  form.origin = GURL("https://myform.com/form.html");
+  form.action = GURL("https://myform.com/submit.html");
+  FormFieldData field;
+  // Set a valid autocomplete attribute for the first name.
+  test::CreateTestFormField("First name", "firstname", "", "text", &field);
+  field.autocomplete_attribute = "given-name";
+  form.fields.push_back(field);
+  // Set no autocomplete attribute for the middle name.
+  test::CreateTestFormField("Middle name", "middle", "", "text", &field);
+  field.autocomplete_attribute = "";
+  form.fields.push_back(field);
+  // Set an unrecognized autocomplete attribute for the last name.
+  test::CreateTestFormField("Last Name", "lastname", "", "text", &field);
+  field.autocomplete_attribute = "unrecognized";
+  form.fields.push_back(field);
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+
+  // Suggestions should be returned for the first two fields
+  GetAutofillSuggestions(form, form.fields[0]);
+  EXPECT_TRUE(external_delegate_->on_suggestions_returned_seen());
+  GetAutofillSuggestions(form, form.fields[1]);
+  EXPECT_TRUE(external_delegate_->on_suggestions_returned_seen());
+
+  // Suggestions should not be returned for the third field because of its
+  // unrecognized autocomplete attribute.
+  GetAutofillSuggestions(form, form.fields[2]);
+  EXPECT_FALSE(external_delegate_->on_suggestions_returned_seen());
+}
+
 // Test that no suggestions are returned when there are less than three fields
 // and none of them have an autocomplete attribute.
 TEST_F(AutofillManagerTest, GetProfileSuggestions_SmallFormNoAutocomplete) {
   FormData form;
   form.name = ASCIIToUTF16("MyForm");
   form.origin = GURL("https://myform.com/form.html");
   form.action = GURL("https://myform.com/submit.html");
   FormFieldData field;
   test::CreateTestFormField("First Name", "firstname", "", "text", &field);
   form.fields.push_back(field);
@@ skipping 868 matching lines @@
   {
     FillAutofillFormDataAndSaveResults(kPageID2, form, form.fields.back(),
                                        MakeFrontendID(guid2, std::string()),
                                        &response_page_id, &response_data);
     SCOPED_TRACE("Credit card");
     ExpectFilledCreditCardFormElvis(
         response_page_id, response_data, kPageID2, true);
   }
 }
 
+// Test that a field with an unrecognized autocomplete attribute is not filled.
+TEST_F(AutofillManagerTest, FillAddressForm_UnrecognizedAttribute) {
+  FormData address_form;
+  address_form.name = ASCIIToUTF16("MyForm");
+  address_form.origin = GURL("https://myform.com/form.html");
+  address_form.action = GURL("https://myform.com/submit.html");
+  FormFieldData field;
+  // Set a valid autocomplete attribute for the first name.
+  test::CreateTestFormField("First name", "firstname", "", "text", &field);
+  field.autocomplete_attribute = "given-name";
+  address_form.fields.push_back(field);
+  // Set no autocomplete attribute for the middle name.
+  test::CreateTestFormField("Middle name", "middle", "", "text", &field);
+  field.autocomplete_attribute = "";
+  address_form.fields.push_back(field);
+  // Set an unrecognized autocomplete attribute for the last name.
+  test::CreateTestFormField("Last name", "lastname", "", "text", &field);
+  field.autocomplete_attribute = "unrecognized";
+  address_form.fields.push_back(field);
+  std::vector<FormData> address_forms(1, address_form);
+  FormsSeen(address_forms);
+
+  // Fill the address form.
+  const char guid[] = "00000000-0000-0000-0000-000000000001";
+  int response_page_id = 0;
+  FormData response_data;
+  FillAutofillFormDataAndSaveResults(
+      kDefaultPageID, address_form, address_form.fields[0],
+      MakeFrontendID(std::string(), guid), &response_page_id, &response_data);
+
+  // The fist and middle names should be filled.
+  ExpectFilledField("First name", "firstname", "Elvis", "text",
+                    response_data.fields[0]);
+  ExpectFilledField("Middle name", "middle", "Aaron", "text",
+                    response_data.fields[1]);
+
+  // The last name should not be filled.
+  ExpectFilledField("Last name", "lastname", "", "text",
+                    response_data.fields[2]);
+}
+
 // Test that non credit card related fields with the autocomplete attribute set
 // to off are not filled on desktop.
 TEST_F(AutofillManagerTest, FillAddressForm_AutocompleteOff) {
   FormData address_form;
   address_form.name = ASCIIToUTF16("MyForm");
   address_form.origin = GURL("https://myform.com/form.html");
   address_form.action = GURL("https://myform.com/submit.html");
   FormFieldData field;
   test::CreateTestFormField("First name", "firstname", "", "text", &field);
   address_form.fields.push_back(field);
@@ skipping 37 matching lines @@
   // The address line 1 should not be filled on desktop.
   if (IsDesktopPlatform()) {
     ExpectFilledField("Address Line 1", "addr1", "", "text",
                       response_data.fields[3]);
   } else {
     ExpectFilledField("Address Line 1", "addr1", "3734 Elvis Presley Blvd.",
                       "text", response_data.fields[3]);
   }
 }
 
+// Test that a field with an unrecognized autocomplete attribute is not filled.
+TEST_F(AutofillManagerTest, FillCreditCardForm_UnrecognizedAttribute) {
+  // Set up the form data.
+  FormData form;
+  form.name = ASCIIToUTF16("MyForm");
+  form.origin = GURL("https://myform.com/form.html");
+  form.action = GURL("https://myform.com/submit.html");
+
+  FormFieldData field;
+  // Set a valid autocomplete attribute on the card name.
+  test::CreateTestFormField("Name on Card", "nameoncard", "", "text", &field);
+  field.autocomplete_attribute = "cc-name";
+  form.fields.push_back(field);
+  // Set no autocomplete attribute on the card number.
+  test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field);
+  field.autocomplete_attribute = "";
+  form.fields.push_back(field);
+  // Set an unrecognized autocomplete attribute on the expiration month.
+  test::CreateTestFormField("Expiration Date", "ccmonth", "", "text", &field);
+  field.autocomplete_attribute = "unrecognized";
+  form.fields.push_back(field);
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+
+  const char guid[] = "00000000-0000-0000-0000-000000000004";
+  int response_page_id = 0;
+  FormData response_data;
+  FillAutofillFormDataAndSaveResults(kDefaultPageID, form, *form.fields.begin(),
+                                     MakeFrontendID(guid, std::string()),
+                                     &response_page_id, &response_data);
+
+  // The credit card name and number should be filled.
+  ExpectFilledField("Name on Card", "nameoncard", "Elvis Presley", "text",
+                    response_data.fields[0]);
+  ExpectFilledField("Card Number", "cardnumber", "4234567890123456", "text",
+                    response_data.fields[1]);
+
+  // The expiration month should not be filled.
+  ExpectFilledField("Expiration Date", "ccmonth", "", "text",
+                    response_data.fields[2]);
+}
+
 // Test that credit card fields are filled even if they have the autocomplete
 // attribute set to off.
 TEST_F(AutofillManagerTest, FillCreditCardForm_AutocompleteOff) {
   // Set up our form data.
   FormData form;
   CreateTestCreditCardFormData(&form, true, false);
 
   // Set the autocomplete=off on all fields.
   for (FormFieldData field : form.fields)
     field.should_autocomplete = false;
@@ skipping 1459 matching lines @@
   form.fields[2].value = ASCIIToUTF16("theking@gmail.com");
   autofill_manager_->OnDidFillAutofillFormData(form, base::TimeTicks::Now());
 
   autofill_manager_->ResetRunLoop();
   // Simulate lost of focus on the form.
   autofill_manager_->OnFocusNoLongerOnForm();
   // Wait for upload to complete.
   autofill_manager_->WaitForAsyncUploadProcess();
 }
 
+// Test that no suggestions are returned for a field with an unrecognized
+// autocomplete attribute.
+TEST_F(AutofillManagerTest, GetCreditCardSuggestions_UnrecognizedAttribute) {
+  // Set up the form data.
+  FormData form;
+  form.name = ASCIIToUTF16("MyForm");
+  form.origin = GURL("https://myform.com/form.html");
+  form.action = GURL("https://myform.com/submit.html");
+
+  FormFieldData field;
+  // Set a valid autocomplete attribute on the card name.
+  test::CreateTestFormField("Name on Card", "nameoncard", "", "text", &field);
+  field.autocomplete_attribute = "cc-name";
+  form.fields.push_back(field);
+  // Set no autocomplete attribute on the card number.
+  test::CreateTestFormField("Card Number", "cardnumber", "", "text", &field);
+  field.autocomplete_attribute = "";
+  form.fields.push_back(field);
+  // Set an unrecognized autocomplete attribute on the expiration month.
+  test::CreateTestFormField("Expiration Date", "ccmonth", "", "text", &field);
+  field.autocomplete_attribute = "unrecognized";
+  form.fields.push_back(field);
+  std::vector<FormData> forms(1, form);
+  FormsSeen(forms);
+
+  // Suggestions should be returned for the first two fields
+  GetAutofillSuggestions(form, form.fields[0]);
+  EXPECT_TRUE(external_delegate_->on_suggestions_returned_seen());
+  GetAutofillSuggestions(form, form.fields[1]);
+  EXPECT_TRUE(external_delegate_->on_suggestions_returned_seen());
+
+  // Suggestions should not be returned for the third field because of its
+  // unrecognized autocomplete attribute.
+  GetAutofillSuggestions(form, form.fields[2]);
+  EXPECT_FALSE(external_delegate_->on_suggestions_returned_seen());
+}
+
 // Test to verify suggestions appears for forms having credit card number split
 // across fields.
 TEST_F(AutofillManagerTest, GetCreditCardSuggestionsForNumberSpitAcrossFields) {
   // Set up our form data with credit card number split across fields.
   FormData form;
   form.name = ASCIIToUTF16("MyForm");
   form.origin = GURL("https://myform.com/form.html");
   form.action = GURL("https://myform.com/submit.html");
 
   FormFieldData name_field;
@@ skipping 609 matching lines @@
   FormsSeen(mixed_forms);
 
   // Suggestions should always be displayed.
   for (const FormFieldData& field : mixed_form.fields) {
     GetAutofillSuggestions(mixed_form, field);
     EXPECT_TRUE(external_delegate_->on_suggestions_returned_seen());
   }
 }
 
 }  // namespace autofill