Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1583503002: Handle saved password deletion when preference has been recreated (Closed)

Created:
4 years, 11 months ago by Theresa
Modified:
4 years, 11 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2564
Target Ref:
refs/pending/branch-heads/2564
Project:
chromium
Visibility:
Public.

Description

Handle saved password deletion when preference has been recreated Previously, if the PreferenceFragment was recreated after returning to the preference after attempting to delete a saved password, the password list wouldn't be available and PasswordManagerPresenter would fail to delete the password. Now, password deletion is handled by PasswordEntryEditor, which always updates the password list before attempting to delete. BUG=575370 TBR=newt@chromium.org Review URL: https://codereview.chromium.org/1571513003 Cr-Commit-Position: refs/heads/master@{#368785} Committed: https://chromium.googlesource.com/chromium/src/+/750369b66fbe7515d0d9efc7fdc47003ebba3d3f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -42 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java View 3 chunks +32 lines, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java View 4 chunks +3 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Theresa
4 years, 11 months ago (2016-01-12 17:13:53 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
750369b66fbe7515d0d9efc7fdc47003ebba3d3f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698