Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 15835004: Files.app: Added column dividers. (Closed)

Created:
7 years, 7 months ago by hirono
Modified:
7 years, 6 months ago
CC:
chromium-reviews, rginda+watch_chromium.org, arv+watch_chromium.org
Visibility:
Public.

Description

Files.app: Added column dividers. Originally column dividers are hidden by 'display:none'; This CL updated the CSS for column dividers and make them visible. BUG=238867 TEST=manually R=yoshiki@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202484

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/resources/file_manager/css/file_manager.css View 1 chunk +9 lines, -1 line 0 comments Download
A chrome/browser/resources/file_manager/images/files/ui/new-ui/2x/vertical_separator.png View Binary file 0 comments Download
A chrome/browser/resources/file_manager/images/files/ui/new-ui/vertical_separator.png View Binary file 0 comments Download

Messages

Total messages: 6 (0 generated)
hirono
Yoshiki-san, Could you check this CL to enable column dividers? Thank you!
7 years, 7 months ago (2013-05-27 05:57:11 UTC) #1
yoshiki
lgtm
7 years, 6 months ago (2013-05-28 02:08:48 UTC) #2
hirono
On 2013/05/28 02:08:48, yoshiki wrote: > lgtm Thanks again!
7 years, 6 months ago (2013-05-28 02:09:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/hirono@chromium.org/15835004/1
7 years, 6 months ago (2013-05-28 02:10:15 UTC) #4
commit-bot: I haz the power
Can't process patch for file chrome/browser/resources/file_manager/images/files/ui/new-ui/2x/vertical_separator.png. Binary file support is temporarilly disabled due to a ...
7 years, 6 months ago (2013-05-28 02:10:16 UTC) #5
hirono
7 years, 6 months ago (2013-05-28 02:32:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 manually as r202484 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698