base/trace_event/memory_allocator_dump.cc - Issue 1583483002: [tracing] Add method to create "weak" global dumps

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/trace_event/memory_allocator_dump.cc

Issue 1583483002: [tracing] Add method to create "weak" global dumps (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Nits. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/trace_event/memory_allocator_dump.cc

diff --git a/base/trace_event/memory_allocator_dump.cc b/base/trace_event/memory_allocator_dump.cc

index 5c5af7ee45842e716b92c5fcf7018641a3bfb023..6f526f93590e37d63d61badaa53b6db17890effd 100644

--- a/base/trace_event/memory_allocator_dump.cc

+++ b/base/trace_event/memory_allocator_dump.cc

@@ -90,6 +90,8 @@ void MemoryAllocatorDump::AsValueInto(TracedValue* value) const {

value->BeginDictionaryWithCopiedName(absolute_name_);

value->SetString("guid", guid_.ToString());

value->SetValue("attrs", *attributes_);

+ if (flags_)

+ value->SetInteger("flags", static_cast<int>(flags_));

value->EndDictionary(); // "allocator_name/heap_subheap": { ... }

}