[parser cleanup] Use BlockState consistently in Parser

[parser cleanup] Use BlockState consistently in Parser

This avoids manual, fragile assignment to Parser::scope_. And once all such
assignments are removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.

Committed: https://crrev.com/f17e9adf99f6abb15b5c37115c707512227b88af
Cr-Commit-Position: refs/heads/master@{#33313}

[adamk, 2016-01-12 22:35:09]

Description was changed from

==========
[parser cleanup] Use BlockState in more places

This avoids manual, fragile assignment to Parser::scope_. And if all such
assignments can be removed, BlockState might become much more valuable as
a place to reset scope-related state.
==========

to

==========
[parser cleanup] Use BlockState in more places

This avoids manual, fragile assignment to Parser::scope_. And if all such
assignments can be removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.
==========

[adamk, 2016-01-12 22:49:44]

Description was changed from

==========
[parser cleanup] Use BlockState in more places

This avoids manual, fragile assignment to Parser::scope_. And if all such
assignments can be removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.
==========

to

==========
[parser cleanup] Use BlockState consistently in Parser

This avoids manual, fragile assignment to Parser::scope_. And once all such
assignments are removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.
==========

[adamk, 2016-01-12 22:53:18]

adamk@chromium.org changed reviewers:
+ littledan@chromium.org

[Dan Ehrenberg, 2016-01-14 18:54:10]

lgtm

[adamk, 2016-01-14 18:57:51]

The CQ bit was checked by adamk@chromium.org

[commit-bot: I haz the power, 2016-01-14 18:58:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583453003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583453003/20001

[commit-bot: I haz the power, 2016-01-14 19:25:13]

Description was changed from

==========
[parser cleanup] Use BlockState consistently in Parser

This avoids manual, fragile assignment to Parser::scope_. And once all such
assignments are removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.
==========

to

==========
[parser cleanup] Use BlockState consistently in Parser

This avoids manual, fragile assignment to Parser::scope_. And once all such
assignments are removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.
==========

[commit-bot: I haz the power, 2016-01-14 19:25:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-14 19:25:35]

Description was changed from

==========
[parser cleanup] Use BlockState consistently in Parser

This avoids manual, fragile assignment to Parser::scope_. And once all such
assignments are removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.
==========

to

==========
[parser cleanup] Use BlockState consistently in Parser

This avoids manual, fragile assignment to Parser::scope_. And once all such
assignments are removed, BlockState might become much more valuable as
a place to reset scope-related state.

Also remove unnecessary nullptr checks after calls to FinalizeBlockScope.

Committed: https://crrev.com/f17e9adf99f6abb15b5c37115c707512227b88af
Cr-Commit-Position: refs/heads/master@{#33313}
==========

[commit-bot: I haz the power, 2016-01-14 19:25:36]

Patchset 2 (id:??) landed as
https://crrev.com/f17e9adf99f6abb15b5c37115c707512227b88af
Cr-Commit-Position: refs/heads/master@{#33313}