Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1583453002: clamp fixed divide to 32 bits (Closed)

Created:
4 years, 11 months ago by caryclark
Modified:
4 years, 11 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

clamp fixed divide to 32 bits In SkEdge::setLine, the numerator is a 26.6 fixed number. SkFixedDiv shifts it up by an additional 16 bits. If the y interval is small, the result overflows 32 bits. The code pins in 64 bit space before down-casting the result. R=reed@google.com BUG=skia:4708 GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1583453002 Committed: https://skia.googlesource.com/skia/+/c63a0f8fe534eef8d52abc2066126729be9b497c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M include/core/SkFixed.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
caryclark
4 years, 11 months ago (2016-01-12 14:22:30 UTC) #2
reed1
lgtm
4 years, 11 months ago (2016-01-12 15:03:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583453002/1
4 years, 11 months ago (2016-01-12 15:08:32 UTC) #5
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 15:21:22 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c63a0f8fe534eef8d52abc2066126729be9b497c

Powered by Google App Engine
This is Rietveld 408576698