Source/bindings/tests/results/V8TestInterface.cpp - Issue 15834008: Auto-generate V8CSSStyleDeclaration::namedPropertyGetter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/V8TestInterface.cpp

Issue 15834008: Auto-generate V8CSSStyleDeclaration::namedPropertyGetter (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/scripts/CodeGeneratorV8.pm ('K') | « Source/bindings/scripts/CodeGeneratorV8.pm ('k') | Source/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp » ('j') | Source/core/core.gypi » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/V8TestInterface.cpp

diff --git a/Source/bindings/tests/results/V8TestInterface.cpp b/Source/bindings/tests/results/V8TestInterface.cpp

index 33ffe66524778d7b5f4a19118a1131cb042d54aa..58b5b59a2c77086fb5247b8ccd5b231c399a8c67 100644

--- a/Source/bindings/tests/results/V8TestInterface.cpp

+++ b/Source/bindings/tests/results/V8TestInterface.cpp

@@ -537,9 +537,9 @@ v8::Handle<v8::Value> V8TestInterface::namedPropertyGetter(v8::Local<v8::String>

bool element1Enabled = false;

RefPtr<NodeList> element1;

collection->getItem(propertyName, element0Enabled, element0, element1Enabled, element1);

- if (element0Enabled && !!element0)

+ if (element0Enabled)

return toV8Fast(element0.release(), info, collection);

- if (element1Enabled && !!element1)

+ if (element1Enabled)

return toV8Fast(element1.release(), info, collection);

return v8Undefined();

}