bluetooth: Invalidate connection objects if a connection fails and add histograms

device/bluetooth/bluetooth_device_unittest.cc

Index: device/bluetooth/bluetooth_device_unittest.cc
diff --git a/device/bluetooth/bluetooth_device_unittest.cc b/device/bluetooth/bluetooth_device_unittest.cc
index 69410b55ad3904c1e6c017ed76c35a3ddec1b7e3..a530f5f20f3003806994f2ca77951b9ba348851b 100644
--- a/device/bluetooth/bluetooth_device_unittest.cc
+++ b/device/bluetooth/bluetooth_device_unittest.cc
@@ -455,9 +455,8 @@ TEST_F(BluetoothTest, BluetoothGattConnection_ErrorAfterConnection) {
   device->CreateGattConnection(GetGattConnectionCallback(Call::NOT_EXPECTED),
                                GetConnectErrorCallback(Call::EXPECTED));
   EXPECT_EQ(1, gatt_connection_attempts_);
-  SimulateGattConnectionError(device, BluetoothDevice::ERROR_AUTH_FAILED);
   SimulateGattConnectionError(device, BluetoothDevice::ERROR_FAILED);

[scheib, 2016/01/16 23:59:52]

This test is intentionally sending 2 errors and expecting only the first to be
reported. Please report 2.

I'd prefer them to have different values as well, so the test can verify that it
is the first value that is passed - but if the enums are cleared out that won't
happen. Perhaps add a TODO for restoring that behavior when the enums are fixed.

[ortuno, 2016/01/19 20:40:08]

Done.

-  EXPECT_EQ(BluetoothDevice::ERROR_AUTH_FAILED, last_connect_error_code_);
+  EXPECT_EQ(BluetoothDevice::ERROR_FAILED, last_connect_error_code_);
   for (BluetoothGattConnection* connection : gatt_connections_)
     EXPECT_FALSE(connection->IsConnected());
 }