Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1583333003: bluetooth: Invalidate connection objects if a connection fails and add histograms (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin
Patch Set: Address scheib's comments Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« device/bluetooth/test/bluetooth_test_android.cc ('K') | « device/bluetooth/test/bluetooth_test_android.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 9408830315883a284400f75d767ced03692ce997..99988e87308ee232688860a1d9d512806324284f 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -3149,6 +3149,39 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="Bluetooth.Android.GATTConnection.Disconnected.Result"
+ enum="AndroidGATTConnectionErrorCodes">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Disconnected GATT connection status codes. Used to better understand errors
+ seen in Android.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Android.GATTConnection.Failure.Result"
+ enum="AndroidGATTConnectionErrorCodes">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Failed GATT connection error codes. Used to better understand errors seen in
+ Android.
+ </summary>
+</histogram>
+
+<histogram name="Bluetooth.Android.GATTConnection.Success.Result"
+ enum="AndroidGATTConnectionErrorCodes">
+ <owner>jyasskin@chromium.org</owner>
+ <owner>ortuno@chromium.org</owner>
+ <owner>scheib@chromium.org</owner>
+ <summary>
+ Successful GATT connection result codes. Used to better understand Android
+ results.
+ </summary>
+</histogram>
+
<histogram name="Bluetooth.ConnectedDeviceCount" units="devices">
<owner>keybuk@chromium.org</owner>
<summary>
@@ -56187,6 +56220,84 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="4" label="EvictAll"/>
</enum>
+<enum name="AndroidGATTConnectionErrorCodes" type="int">
+ <int value="0" label="0x00 Success"/>
scheib 2016/01/16 23:59:52 Comment the sources of the error codes. Are the GA
ortuno 2016/01/19 20:40:08 Done.
+ <int value="1" label="0x01 Unknown HCI Command"/>
+ <int value="2" label="0x02 Unknown Connection Identifier"/>
+ <int value="3" label="0x03 Hardware Failure"/>
+ <int value="4" label="0x04 Page Timeout"/>
+ <int value="5" label="0x05 Authentication Failure"/>
+ <int value="6" label="0x06 PIN or Key Missing"/>
+ <int value="7" label="0x07 Memory Capacity Exceeded"/>
+ <int value="8" label="0x08 Connection Timeout"/>
+ <int value="9" label="0x09 Connection Limit Exceeded"/>
+ <int value="10"
+ label="0x0A Synchronous Connection Limit To A Device Exceeded"/>
+ <int value="11" label="0x0B ACL Connection Already Exists"/>
+ <int value="12" label="0x0C Command Disallowed"/>
+ <int value="13" label="0x0D Connection Rejected due to Limited Resources"/>
+ <int value="14" label="0x0E Connection Rejected Due To Security Reasons"/>
+ <int value="15" label="0x0F Connection Rejected due to Unacceptable BD_ADDR"/>
+ <int value="16" label="0x10 Connection Accept Timeout Exceeded"/>
+ <int value="17" label="0x11 Unsupported Feature or Parameter Value"/>
+ <int value="18" label="0x12 Invalid HCI Command Parameters"/>
+ <int value="19" label="0x13 Remote User Terminated Connection"/>
+ <int value="20"
+ label="0x14 Remote Device Terminated Connection due to Low Resources"/>
+ <int value="21"
+ label="0x15 Remote Device Terminated Connection due to Power Off"/>
+ <int value="22" label="0x16 Connection Terminated By Local Host"/>
+ <int value="23" label="0x17 Repeated Attempts"/>
+ <int value="24" label="0x18 Pairing Not Allowed"/>
+ <int value="25" label="0x19 Unknown LMP PDU"/>
+ <int value="26"
+ label="0x1A Unsupported Remote Feature / Unsupported LMP Feature"/>
+ <int value="27" label="0x1B SCO Offset Rejected"/>
+ <int value="28" label="0x1C SCO Interval Rejected"/>
+ <int value="29" label="0x1D SCO Air Mode Rejected"/>
+ <int value="30" label="0x1E Invalid LMP Parameters / Invalid LL Parameters"/>
+ <int value="31" label="0x1F Unspecified Error"/>
+ <int value="32"
+ label="0x20 Unsupported LMP Parameter Value / Unsupported LL Parameter
+ Value"/>
+ <int value="33" label="0x21 Role Change Not Allowed"/>
+ <int value="34" label="0x22 LMP Response Timeout / LL Response Timeout"/>
+ <int value="35" label="0x23 LMP Error Transaction Collision"/>
+ <int value="36" label="0x24 LMP PDU Not Allowed"/>
+ <int value="37" label="0x25 Encryption Mode Not Acceptable"/>
+ <int value="38" label="0x26 Link Key cannot be Changed"/>
+ <int value="39" label="0x27 Requested QoS Not Supported"/>
+ <int value="40" label="0x28 Instant Passed"/>
+ <int value="41" label="0x29 Pairing With Unit Key Not Supported"/>
+ <int value="42" label="0x2A Different Transaction Collision"/>
+ <int value="43" label="0x2B Reserved"/>
+ <int value="44" label="0x2C QoS Unacceptable Parameter"/>
+ <int value="45" label="0x2D QoS Rejected"/>
+ <int value="46" label="0x2E Channel Classification Not Supported"/>
+ <int value="47" label="0x2F Insufficient Security"/>
+ <int value="48" label="0x30 Parameter Out Of Mandatory Range"/>
+ <int value="49" label="0x31 Reserved"/>
+ <int value="50" label="0x32 Role Switch Pending"/>
+ <int value="51" label="0x33 Reserved"/>
+ <int value="52" label="0x34 Reserved Slot Violation"/>
+ <int value="53" label="0x35 Role Switch Failed"/>
+ <int value="54" label="0x36 Extended Inquiry Response Too Large"/>
+ <int value="55" label="0x37 Secure Simple Pairing Not Supported By Host"/>
+ <int value="56" label="0x38 Host Busy - Pairing"/>
+ <int value="57"
+ label="0x39 Connection Rejected due to No Suitable Channel Found"/>
+ <int value="58" label="0x3A Controller Busy"/>
+ <int value="59" label="0x3B Unacceptable Connection Parameters"/>
+ <int value="60" label="0x3C Directed Advertising Timeout"/>
+ <int value="61" label="0x3D Connection Terminated due to MIC Failure"/>
+ <int value="62" label="0x3E Connection Failed to be Established"/>
+ <int value="63" label="0x3F MAC Connection Failed"/>
+ <int value="64"
+ label="0x40 Coarse Clock Adjustment Rejected but Will Try to Adjust
+ Using Clock Dragging"/>
scheib 2016/01/16 23:59:52 Should this one from bluedroid be included? GATT_C
ortuno 2016/01/19 20:40:09 Done.
+ <int value="257" label="0x101 Android GATT Failure"/>
+</enum>
+
<enum name="AndroidKernelVersion" type="int">
<int value="131078" label="2.6"/>
<int value="196608" label="3.0"/>
« device/bluetooth/test/bluetooth_test_android.cc ('K') | « device/bluetooth/test/bluetooth_test_android.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698