Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Unified Diff: Source/core/html/shadow/MediaControlsChromiumAndroid.cpp

Issue 158333002: Merge MediaControlsChromium into MediaControls (2nd try) (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: if OS(ANDRIOD) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/html/shadow/MediaControlsChromiumAndroid.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/html/shadow/MediaControlsChromiumAndroid.cpp
diff --git a/Source/core/html/shadow/MediaControlsChromiumAndroid.cpp b/Source/core/html/shadow/MediaControlsChromiumAndroid.cpp
index f81c9309b37d7b509e7d11a6ab2c6fde35fadb7a..6a186b658ddf275046499717f5b616635e14bb2f 100644
--- a/Source/core/html/shadow/MediaControlsChromiumAndroid.cpp
+++ b/Source/core/html/shadow/MediaControlsChromiumAndroid.cpp
@@ -32,42 +32,29 @@
namespace WebCore {
MediaControlsChromiumAndroid::MediaControlsChromiumAndroid(Document& document)
- : MediaControlsChromium(document)
+ : MediaControls(document)
, m_overlayPlayButton(0)
, m_overlayEnclosure(0)
{
}
-PassRefPtr<MediaControls> MediaControls::create(Document& document)
+bool MediaControlsChromiumAndroid::initializeControls(Document& document)
{
- return MediaControlsChromiumAndroid::createControls(document);
-}
-
-PassRefPtr<MediaControlsChromiumAndroid> MediaControlsChromiumAndroid::createControls(Document& document)
-{
- if (!document.page())
- return 0;
-
- RefPtr<MediaControlsChromiumAndroid> controls = adoptRef(new MediaControlsChromiumAndroid(document));
-
TrackExceptionState exceptionState;
RefPtr<MediaControlOverlayEnclosureElement> overlayEnclosure = MediaControlOverlayEnclosureElement::create(document);
RefPtr<MediaControlOverlayPlayButtonElement> overlayPlayButton = MediaControlOverlayPlayButtonElement::create(document);
- controls->m_overlayPlayButton = overlayPlayButton.get();
+ m_overlayPlayButton = overlayPlayButton.get();
overlayEnclosure->appendChild(overlayPlayButton.release(), exceptionState);
if (exceptionState.hadException())
- return 0;
+ return false;
- controls->m_overlayEnclosure = overlayEnclosure.get();
- controls->appendChild(overlayEnclosure.release(), exceptionState);
+ m_overlayEnclosure = overlayEnclosure.get();
+ appendChild(overlayEnclosure.release(), exceptionState);
if (exceptionState.hadException())
- return 0;
-
- if (controls->initializeControls(document))
- return controls.release();
+ return false;
- return 0;
+ return MediaControls::initializeControls(document);
}
void MediaControlsChromiumAndroid::setMediaController(MediaControllerInterface* controller)
@@ -76,19 +63,19 @@ void MediaControlsChromiumAndroid::setMediaController(MediaControllerInterface*
m_overlayPlayButton->setMediaController(controller);
if (m_overlayEnclosure)
m_overlayEnclosure->setMediaController(controller);
- MediaControlsChromium::setMediaController(controller);
+ MediaControls::setMediaController(controller);
}
void MediaControlsChromiumAndroid::playbackStarted()
{
m_overlayPlayButton->updateDisplayType();
- MediaControlsChromium::playbackStarted();
+ MediaControls::playbackStarted();
}
void MediaControlsChromiumAndroid::playbackStopped()
{
m_overlayPlayButton->updateDisplayType();
- MediaControlsChromium::playbackStopped();
+ MediaControls::playbackStopped();
}
void MediaControlsChromiumAndroid::insertTextTrackContainer(PassRefPtr<MediaControlTextTrackContainerElement> textTrackContainer)
« no previous file with comments | « Source/core/html/shadow/MediaControlsChromiumAndroid.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698