Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 1583323004: [turbofan] Add the TruncateFloat32ToInt32 operator to turbofan. (Closed)

Created:
4 years, 11 months ago by ahaas
Modified:
4 years, 11 months ago
Reviewers:
Weiliang, titzer, v8-arm-ports, v8-mips-ports
CC:
v8-ppc-ports_googlegroups.com, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add the TruncateFloat32ToInt32 operator to turbofan. The new operator converts a float32 input to int32 through truncation. I provide implementations of the new operator for x64, ia32, arm, arm64, mips, mips64, and x87. @v8-ppc-ports, can you please take care of the ppc implementation? R=titzer@chromium.org, v8-arm-ports@googlegroups.com, v8-mips-ports@googlegroups.com, weiliang.lin@intel.com Committed: https://crrev.com/fc53eed14b2366ceb24b1ad1da5d70533a1e7830 Cr-Commit-Position: refs/heads/master@{#33346}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Build problem on a try bot. #

Patch Set 3 : Fixed a small bug #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -15 lines) Patch
M src/arm/assembler-arm.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/arm/assembler-arm.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/arm/instruction-codes-arm.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-scheduler-arm.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm/instruction-selector-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-scheduler-arm64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/ia32/instruction-codes-ia32.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-scheduler-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M src/compiler/x64/instruction-codes-x64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-scheduler-x64.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/x87/code-generator-x87.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-codes-x87.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/x64/assembler-x64.h View 1 2 1 chunk +8 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +20 lines, -0 lines 0 comments Download
M test/cctest/compiler/codegen-tester.h View 1 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
ahaas
4 years, 11 months ago (2016-01-15 12:17:39 UTC) #1
titzer
lgtm other than one small bug https://codereview.chromium.org/1583323004/diff/1/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/1583323004/diff/1/src/compiler/instruction-selector.cc#newcode960 src/compiler/instruction-selector.cc:960: return MarkAsWord64(node), VisitTruncateFloat32ToInt32(node); ...
4 years, 11 months ago (2016-01-15 12:39:27 UTC) #2
ahaas
https://codereview.chromium.org/1583323004/diff/1/src/compiler/instruction-selector.cc File src/compiler/instruction-selector.cc (right): https://codereview.chromium.org/1583323004/diff/1/src/compiler/instruction-selector.cc#newcode960 src/compiler/instruction-selector.cc:960: return MarkAsWord64(node), VisitTruncateFloat32ToInt32(node); On 2016/01/15 at 12:39:27, titzer wrote: ...
4 years, 11 months ago (2016-01-15 12:52:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583323004/30001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583323004/30001
4 years, 11 months ago (2016-01-16 08:02:43 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 11 months ago (2016-01-16 11:40:54 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 11:41:39 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/fc53eed14b2366ceb24b1ad1da5d70533a1e7830
Cr-Commit-Position: refs/heads/master@{#33346}

Powered by Google App Engine
This is Rietveld 408576698