Changes to Autofill settings page to ensure Credit Card list is always at least partially visible o…

chrome/browser/resources/options/autofill_options.css

Index: chrome/browser/resources/options/autofill_options.css
diff --git a/chrome/browser/resources/options/autofill_options.css b/chrome/browser/resources/options/autofill_options.css
index 815c58c40790585847ab06eb9b40229a286f3e08..652b755d2e058a7e47d34c6fcceb85a70434f820 100644
--- a/chrome/browser/resources/options/autofill_options.css
+++ b/chrome/browser/resources/options/autofill_options.css
@@ -7,7 +7,7 @@
 }
 
 #autofill-options list {
-  min-height: 172px;
+  height: 192px;  /* This is the min-height for lists from WebUI.*/

[Dan Beam, 2016/01/28 01:35:13]

i don't understand what this comment adds

[tmartino, 2016/01/28 19:09:56]

Just trying not to leave an undocumented Magic Number floating around--it's a
seemingly-arbitrary value that's actually dictated by an external constraint.
Still, I can remove it if you find it to be more noise than signal.

 }
 
 .autofill-list-item {
@@ -38,7 +38,7 @@
 
 #autofill-add-address,
 #autofill-add-creditcard {
-  margin: 5px 5px;
+  margin: 5px 0;
 }
 
 #autofill-options .list-inline-button {
@@ -56,3 +56,13 @@
     .hides-on-hover {
   display: none;
 }
+
+#autofill-options .extra-margin {

[Dan Beam, 2016/01/28 01:35:13]

could this just be

.settings-list + .autofill-section-header {
  margin-top: 20px;
}

and we nuke the extra-margin class?

[tmartino, 2016/01/28 19:09:56]

Done.

+  margin-bottom: 20px;
+}
+
+#autofill-options .autofill-section-header {
+  display: flex;
+  justify-content: space-between;
+  margin-bottom: 5px;
+}