Convert commitText("\n") to synthetic Enter key press.

Convert commitText("\n") to synthetic Enter key press.

One known WebView app has come to rely on examining KeyDown key code in
JS to detect Enter key presses.  To avoid breaking it, restore the
conversion to KeyDown/KeyUp pair that was removed in
http://crrev.com/1403453002.

BUG=577967
Committed: https://crrev.com/c705f32bec498579e1f54c3e093e7da39ca90c7d
Cr-Commit-Position: refs/heads/master@{#370284}

[aelias_OOO_until_Jul13, 2016-01-16 00:59:56]

aelias@chromium.org changed reviewers:
+ changwan@chromium.org

[aelias_OOO_until_Jul13, 2016-01-16 01:06:35]

Hi changwan@, PTAL.  I think this is needed because 48 is very close to stable,
and there'll be a window of time where users see the bug if they get 48 WebView
but didn't receive an update to the client app.  I don't think the cleanup is
worth the risk that end-users experience breakage.  If we cherry-pick this, then
we can take the time to clean up the OS(ANDROID)s in
https://codereview.chromium.org/1593533002/, let the app deploy a version that
looks at compositionUpdate, and then we can remove it again.

[Changwan Ryu, 2016-01-18 02:35:31]

lgtm

On 2016/01/16 01:06:35, aelias wrote:
> Hi changwan@, PTAL.  I think this is needed because 48 is very close to
stable,
> and there'll be a window of time where users see the bug if they get 48
WebView
> but didn't receive an update to the client app.  I don't think the cleanup is
> worth the risk that end-users experience breakage.  If we cherry-pick this,
then
> we can take the time to clean up the OS(ANDROID)s in
> https://codereview.chromium.org/1593533002/, let the app deploy a version that
> looks at compositionUpdate, and then we can remove it again.

Agreed. 

Could you add a test? If you call commitText() while composing some text, we
replace the composition. If you send enter key while composing some text, we
cancel the composition. The latter behavior might be somewhat unexpected
according to crbug.com/278584. This patch does not change the current behavior
anyways, but just in case we want to keep or change that in the future we may
need a test. Something like this should be sufficient:

testCommitEnterKey_WhileComposingText
        focusElementAndWaitForStateUpdate("textarea");

        setComposingText("hello", 1);
        waitAndVerifyStatesAndCalls(0, "hello", 5, 5, 0, 5);

        // Cancel the current composition and replace it with enter.
        commitText("\n", 1);
        // The second new line is not a user visible/editable one, it is a
side-effect of Blink
        // using <br> internally. This only happens when \n is at the end.
        waitAndVerifyStatesAndCalls(1, "\n\n", 1, 1, -1, -1);

        commitText("world", 1);
        waitAndVerifyStatesAndCalls(2, "\nworld", 6, 6, -1, -1);

[aelias_OOO_until_Jul13, 2016-01-20 00:49:26]

The CQ bit was checked by aelias@chromium.org

[aelias_OOO_until_Jul13, 2016-01-20 00:49:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
changwan@chromium.org
Link to the patchset: https://codereview.chromium.org/1583283008/#ps20001
(title: "Add test")

[commit-bot: I haz the power, 2016-01-20 00:52:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583283008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583283008/20001

[commit-bot: I haz the power, 2016-01-20 02:39:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-20 02:40:53]

Description was changed from

==========
Convert commitText("\n") to synthetic Enter key press.

One known WebView app has come to rely on examining KeyDown key code in
JS to detect Enter key presses.  To avoid breaking it, restore the
conversion to KeyDown/KeyUp pair that was removed in
http://crrev.com/1403453002.

BUG=577967
==========

to

==========
Convert commitText("\n") to synthetic Enter key press.

One known WebView app has come to rely on examining KeyDown key code in
JS to detect Enter key presses.  To avoid breaking it, restore the
conversion to KeyDown/KeyUp pair that was removed in
http://crrev.com/1403453002.

BUG=577967

Committed: https://crrev.com/c705f32bec498579e1f54c3e093e7da39ca90c7d
Cr-Commit-Position: refs/heads/master@{#370284}
==========

[commit-bot: I haz the power, 2016-01-20 02:40:53]

Patchset 2 (id:??) landed as
https://crrev.com/c705f32bec498579e1f54c3e093e7da39ca90c7d
Cr-Commit-Position: refs/heads/master@{#370284}