Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(508)

Issue 1583263007: dart2js cps: Update null checks when updating refinements. (Closed)

Created:
4 years, 11 months ago by asgerf
Modified:
4 years, 11 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

dart2js cps: Update null checks when updating refinements. Also run UpdateRefinements before second type propagation. This cleans up a lot of redundant null checks in the output. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/e5498d1500e6c5729b6e872613429aa166e9e8cb Committed: https://github.com/dart-lang/sdk/commit/b36e28171e3dd99f141f5d0deb096a02f44c0514

Patch Set 1 #

Patch Set 2 : Revert+Unrevert #

Patch Set 3 : Fix type annotations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/update_refinements.dart View 1 2 4 chunks +27 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
asgerf
4 years, 11 months ago (2016-01-19 19:03:44 UTC) #2
Siggi Cherem (dart-lang)
lgtm
4 years, 11 months ago (2016-01-19 19:06:39 UTC) #3
asgerf
Committed patchset #1 (id:1) manually as e5498d1500e6c5729b6e872613429aa166e9e8cb (presubmit successful).
4 years, 11 months ago (2016-01-19 21:44:27 UTC) #5
asgerf
4 years, 11 months ago (2016-01-19 22:57:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
b36e28171e3dd99f141f5d0deb096a02f44c0514 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698