Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 1583243002: Revert of ts_mon: remove dependency on apiclient. (Closed)

Created:
4 years, 11 months ago by Sergiy Byelozyorov
Modified:
4 years, 11 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Base URL:
https://chromium.googlesource.com/infra/infra.git@master
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Revert of ts_mon: remove dependency on apiclient. (patchset #2 id:20001 of https://codereview.chromium.org/1588623002/ ) Reason for revert: This broke chromium_try_flakes. I am not sure why, but after this change I get an error on importing six from gae_ts_mon. Possibly this is because there is another version of six in appengine/third_party. Original issue's description: > ts_mon: remove dependency on apiclient. > > apiclient is just an alias to googleapiclient, and the latter can be > used directly. > > Also remove third_party from gae_ts_mon - move symlinks to the top level. This simplifies vendoring to luci-py. > > R=pgervais@chromium.org > BUG=560481 > > Committed: https://chromium.googlesource.com/infra/infra/+/d64faecc426433933221f7595db46a23155086ac TBR=pgervais@chromium.org,sergiyb@google.com,sergeyberezin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=560481 Committed: https://chromium.googlesource.com/infra/infra/+/6b5a5c043533d47f177e9911af2ce67403aa3120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -8 lines) Patch
M appengine_module/gae_ts_mon/__init__.py View 1 chunk +3 lines, -0 lines 0 comments Download
D appengine_module/gae_ts_mon/googleapiclient View 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/httplib2 View 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/oauth2client View 1 chunk +0 lines, -1 line 0 comments Download
D appengine_module/gae_ts_mon/six.py View 1 chunk +0 lines, -1 line 0 comments Download
A appengine_module/gae_ts_mon/third_party/__init__.py View 1 chunk +11 lines, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/third_party/apiclient View 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/third_party/googleapiclient View 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/third_party/httplib2 View 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/third_party/oauth2client View 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/third_party/six.py View 1 chunk +1 line, -0 lines 0 comments Download
A appengine_module/gae_ts_mon/third_party/uritemplate View 1 chunk +1 line, -0 lines 0 comments Download
D appengine_module/gae_ts_mon/uritemplate View 1 chunk +0 lines, -1 line 0 comments Download
M infra_libs/ts_mon/common/monitors.py View 1 chunk +1 line, -1 line 0 comments Download
M infra_libs/ts_mon/common/test/monitors_test.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Sergiy Byelozyorov
Created Revert of ts_mon: remove dependency on apiclient.
4 years, 11 months ago (2016-01-14 11:22:51 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583243002/1
4 years, 11 months ago (2016-01-14 11:22:59 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/infra/infra/+/6b5a5c043533d47f177e9911af2ce67403aa3120
4 years, 11 months ago (2016-01-14 11:23:14 UTC) #4
pgervais
On 2016/01/14 11:23:14, commit-bot: I haz the power wrote: > Committed patchset #1 (id:1) as ...
4 years, 11 months ago (2016-01-14 17:18:29 UTC) #5
Sergey Berezin
4 years, 11 months ago (2016-01-14 20:36:42 UTC) #6
Message was sent while issue was closed.
LGTM. Thanks for catching this! Re-landing as http://crrev.com/1587933003, this
time tested on an actual app, end-to-end.

Powered by Google App Engine
This is Rietveld 408576698