chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java - Issue 1583233004: Measure time spent during StrictMode violations.

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

Issue 1583233004: Measure time spent during StrictMode violations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove WebappAuthenticator.java and ExternalAuthUtils.java. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

index bae9db2299e9416626a42fa0fd809acc157e61ef..d42071f65e7e60ed3a9baeea62d66642f97de38f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/DocumentTabModelImpl.java

@@ -10,6 +10,7 @@ import android.content.Intent;

import android.content.SharedPreferences;

import android.os.AsyncTask;

import android.os.StrictMode;

+import android.os.SystemClock;

import android.text.TextUtils;

import android.util.Log;

import android.util.Pair;

@@ -21,6 +22,7 @@ import org.chromium.base.ApplicationStatus;

import org.chromium.base.ObserverList;

import org.chromium.base.ThreadUtils;

import org.chromium.base.VisibleForTesting;

+import org.chromium.base.metrics.RecordHistogram;

import org.chromium.chrome.browser.TabState;

import org.chromium.chrome.browser.document.DocumentActivity;

import org.chromium.chrome.browser.document.DocumentMetricIds;

@@ -43,6 +45,7 @@ import java.util.ArrayList;

import java.util.HashSet;

import java.util.List;

import java.util.Set;

+import java.util.concurrent.TimeUnit;

/**

* Maintains a list of Tabs displayed when Chrome is running in document-mode.

@@ -510,8 +513,11 @@ public class DocumentTabModelImpl extends TabModelJniBridge implements DocumentT

// Temporarily allowing disk access while fixing. TODO: http://crbug.com/543201

StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();

try {

+ long time = SystemClock.elapsedRealtime();

entry.setTabState(

mStorageDelegate.restoreTabState(mPrioritizedTabId, isIncognito()));

+ RecordHistogram.recordTimesHistogram("Android.StrictMode.DocumentTabStateLoad",

Ted C 2016/01/26 18:04:30 This can be hit before native library loaded. E/A

+ SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);

} finally {

StrictMode.setThreadPolicy(oldPolicy);

}