Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1640)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

Issue 1583233004: Measure time spent during StrictMode violations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix per review. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
index fe2af4fd64eeeba0a5007f1e79643eb582f19c82..21db4502bd4f6395565875acc2318101a8ca007d 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java
@@ -11,6 +11,7 @@ import android.graphics.drawable.Drawable;
import android.net.Uri;
import android.os.Bundle;
import android.os.StrictMode;
+import android.os.SystemClock;
import android.text.TextUtils;
import android.view.LayoutInflater;
import android.view.View;
@@ -25,6 +26,7 @@ import org.chromium.base.ApplicationStatus;
import org.chromium.base.Log;
import org.chromium.base.StreamUtil;
import org.chromium.base.VisibleForTesting;
+import org.chromium.base.metrics.RecordHistogram;
import org.chromium.blink_public.platform.WebDisplayMode;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.TabState;
@@ -48,6 +50,7 @@ import java.io.File;
import java.io.FileNotFoundException;
import java.io.FileOutputStream;
import java.io.IOException;
+import java.util.concurrent.TimeUnit;
/**
* Displays a webapp in a nearly UI-less Chrome (InfoBars still appear).
@@ -169,8 +172,11 @@ public class WebappActivity extends FullScreenActivity {
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
StrictMode.allowThreadDiskWrites();
try {
+ long time = SystemClock.elapsedRealtime();
foutput = new FileOutputStream(tabFile);
TabState.saveState(foutput, getActivityTab().getState(), false);
+ RecordHistogram.recordTimesHistogram("Android.StrictMode.WebappSaveState",
+ SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
} catch (FileNotFoundException exception) {
Log.e(TAG, "Failed to save out tab state.", exception);
} catch (IOException exception) {
@@ -289,7 +295,7 @@ public class WebappActivity extends FullScreenActivity {
}
mWebappUma.recordSplashscreenIconType(splashScreenIconType);
mWebappUma.recordSplashscreenIconSize(
- Math.round((float) displayIcon.getWidth()
+ Math.round(displayIcon.getWidth()
/ getResources().getDisplayMetrics().density));
}

Powered by Google App Engine
This is Rietveld 408576698