Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5400)

Unified Diff: base/android/java/src/org/chromium/base/PathUtils.java

Issue 1583233004: Measure time spent during StrictMode violations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix per review. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/PathUtils.java
diff --git a/base/android/java/src/org/chromium/base/PathUtils.java b/base/android/java/src/org/chromium/base/PathUtils.java
index fe14c2782c57606c1b6e4a5fb1ef7d2cfe337e54..09c3b082409a052df102c591c3d69709969f1345 100644
--- a/base/android/java/src/org/chromium/base/PathUtils.java
+++ b/base/android/java/src/org/chromium/base/PathUtils.java
@@ -9,12 +9,15 @@ import android.content.pm.ApplicationInfo;
import android.os.AsyncTask;
import android.os.Environment;
import android.os.StrictMode;
+import android.os.SystemClock;
import org.chromium.base.annotations.CalledByNative;
import org.chromium.base.annotations.MainDex;
+import org.chromium.base.metrics.RecordHistogram;
import java.io.File;
import java.util.concurrent.ExecutionException;
+import java.util.concurrent.TimeUnit;
/**
* This class provides the path related methods for the native library.
@@ -106,7 +109,10 @@ public abstract class PathUtils {
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
StrictMode.allowThreadDiskWrites();
try {
+ long time = SystemClock.elapsedRealtime();
sThumbnailDirectory = appContext.getDir(THUMBNAIL_DIRECTORY, Context.MODE_PRIVATE);
+ RecordHistogram.recordTimesHistogram("Android.StrictMode.ThumbnailCacheDir",
+ SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
} finally {
StrictMode.setThreadPolicy(oldPolicy);
}
@@ -127,12 +133,17 @@ public abstract class PathUtils {
private static String getDownloadsDirectory(Context appContext) {
// Temporarily allowing disk access while fixing. TODO: http://crbug.com/508615
StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
+ String downloadsPath;
try {
- return Environment.getExternalStoragePublicDirectory(
+ long time = SystemClock.elapsedRealtime();
+ downloadsPath = Environment.getExternalStoragePublicDirectory(
Environment.DIRECTORY_DOWNLOADS).getPath();
+ RecordHistogram.recordTimesHistogram("Android.StrictMode.DownloadsDir",
+ SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
} finally {
StrictMode.setThreadPolicy(oldPolicy);
}
+ return downloadsPath;
}
/**

Powered by Google App Engine
This is Rietveld 408576698